Support Admonition Blocks and Tabsets?

[BrooklinJazz]

ExDoc supports admonition blocks: https://hexdocs.pm/ex_doc/readme.html#admonition-blocks and tabsets: https://hexdocs.pm/ex_doc/readme.html#tabsets, but Livebook doesn't.

Currently, I build custom HTML elements in the LV markdown or something with Kino if I need to do something like this, but these only sometimes work in ExDoc documentation.

Supporting this directly in Livebook would allow docs/guides to be seamless between both HexDocs and Livebook.

Is the Livebook team open to a PR on this? I won't have the bandwidth for a while, but if I know the team is open to it, I can contribute a PR (Or someone else is welcome to beat me to it!).

[josevalim]

I am ok with admonition, as it is mostly styling. Tabsets require post-processing of the rendered HTML, so I am not sure how affordable it is. @jonatanklosko, do you have thoughts?

[jonatanklosko]

I'm a little bit hesitant going outside of GFM, but if you think it's fine, it's fine by me too :) For both features we would need custom plugins for the JS markdown parsing/rendering though.

[josevalim]

There is a remark-attr which could probably be used as foundation for IAL: https://github.com/arobase-che/remark-attr - although i would only add class support, which would make this easier.