Skip to content

Commit f393a17

Browse files
authored
fix: check for default headers before appending to cors header failures (#4015)
1 parent c5dbb6c commit f393a17

File tree

1 file changed

+6
-2
lines changed
  • litestar/middleware/_internal

1 file changed

+6
-2
lines changed

litestar/middleware/_internal/cors.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,12 @@ def _create_preflight_response(self, origin: str, request_headers: Headers) -> R
113113
response_headers["Access-Control-Allow-Headers"] = ", ".join(
114114
sorted(set(pre_flight_requested_headers) | DEFAULT_ALLOWED_CORS_HEADERS) # pyright: ignore
115115
)
116-
elif any(header.lower() not in self.config.allow_headers for header in pre_flight_requested_headers):
117-
failures.append("headers")
116+
else:
117+
all_allowed_headers = set(self.config.allow_headers).union(
118+
default_header.lower() for default_header in DEFAULT_ALLOWED_CORS_HEADERS
119+
)
120+
if any(header.lower() not in all_allowed_headers for header in pre_flight_requested_headers):
121+
failures.append("headers")
118122

119123
return (
120124
Response(

0 commit comments

Comments
 (0)