(hwp_sys.py) Should we store self.ata and self.atd variables at each observation?

[mj-gomes]

Hello all,

I wanted to understand the reason why in the current hwp_sys.py in the master branch, in the fill_tod function, the self.ata and self.atd variables are set to zero for each observation in here. If we don't compute the map on the fly there is no problem, since the tod is being stored for each observation, but if we want to compute the map on the fly for a set of observations, shouldn't we also be storing the ata and atd objects at each iteration? The way it is done currently, we would only get a map from the last observation.

This is not related to the changes I have done in the code in terms of systematics, but if it is indeed something to change I can also do it and include it in the pull request.

Maybe @sgiardie or @nraffuzz would be able to answer this.

Thank you in advance for the help,
Miguel

[paganol]

Hi @mj-gomes,
thanks for spotting this, you are totally right!
Luckily we usually have only one observation for mpi-task so that loop is usually over just one element, but definitely it should be fixed.
If it's almost zero effort for you, please do that. Thanks!

[mj-gomes]

Alright, it's done. It will be in the pull request. Thank you Luca!