Instructions should not suggest auto-restarting the container

[dechamps]

The current README suggests the use of docker run --restart unless-stopped, which means the container will auto-restart on a crash.

There is a good chance this is what caused some trackers to ban Transmission due to transmission/transmission#7035 - basically, auto-restarting Transmission daemons waging an accidental DDoS attack on trackers.

In general, auto-restarting applications that can generate large amounts of network traffic at startup doesn't sound like a good idea.

Also, auto-restarting tends to hide problems instead of surfacing them so that they can be fixed properly.

The instructions should be updated to remove the suggestion to use --restart unless-stopped (for docker-compose and docker-cli examples). Ideally, a note should also be added to explicitly warn the user against the use of --restart.

Sadly this will not fix incorrect configuration in existing installs, but it will at least stop them from proliferating.

I tried to send a PR myself but couldn't understand how to do this given the README is auto-generated.

[github-actions]

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

[Roxedus]

The container never shutdown from this bug, changing the restart policy wouldn't have mattered. The application crashed, and the supervisor in the container started it again.

[dechamps]

The application crashed, and the supervisor in the container started it again.

Okay. Can we change the supervisor config to not restart Transmission? And then presumably that would still have to be combined with the change I suggested, otherwise it's the container that will restart instead? Maybe if the image is changed to sleep forever if Transmission exits, then this change may actually work without requiring users to change their config?

I feel like this issue should not have been closed. My understanding of the root cause may have been wrong, but auto-restarting Transmission is still problematic regardless of the mechanism that does it.