Skip to content

Commit d512cd4

Browse files
12MB boards: Deduplicate generation of 8MB/4MB split ROMs
Move Makefile targets for split ROMs to targets/split_8mb4mb.mk. Signed-off-by: Jonathon Hall <jonathon.hall@puri.sm>
1 parent c8e1141 commit d512cd4

File tree

20 files changed

+56
-379
lines changed

20 files changed

+56
-379
lines changed

boards/UNTESTED_t530-dgpu-hotp-maximized/UNTESTED_t530-dgpu-hotp-maximized.config

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -74,25 +74,6 @@ export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
7474
# reduced IFD ME region and expanded BIOS IFD region.
7575
# - blobs/xx30/extract.sh
7676
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
#
78-
# This board has two SPI flash chips, an 8 MB that holds the IFD,
79-
# the ME image and part of the coreboot image, and a 4 MB one that
80-
# has the rest of the coreboot and the reset vector.
81-
#
82-
# As a consequence, this replaces the need of having to flash t530-flash
83-
# and expands available CBFS region (11.5Mb available CBFS space)
84-
#
85-
# When flashing via an external programmer it is easiest to have
86-
# two separate files for these pieces.
87-
all: $(board_build)/$(CB_OUTPUT_FILE)
88-
@sha256sum $@ | tee -a "$(HASHES)"
89-
90-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom
91-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom: $(board_build)/$(CB_OUTPUT_FILE)
92-
$(call do,DD 8MB,$@,dd of=$@ if=$< bs=65536 count=128 skip=0 status=none)
93-
@sha256sum $@ | tee -a "$(HASHES)"
9477

95-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom
96-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom: $(board_build)/$(CB_OUTPUT_FILE)
97-
$(call do,DD 4MB,$@,dd of=$@ if=$< bs=65536 count=64 skip=128 status=none)
98-
@sha256sum $@ | tee -a "$(HASHES)"
78+
# Generate split 4MB top / 8MB bottom ROMs
79+
BOARD_TARGETS := split_8mb4mb

boards/UNTESTED_t530-dgpu-maximized/UNTESTED_t530-dgpu-maximized.config

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -74,25 +74,6 @@ export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
7474
# reduced IFD ME region and expanded BIOS IFD region.
7575
# - blobs/xx30/extract.sh
7676
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
#
78-
# This board has two SPI flash chips, an 8 MB that holds the IFD,
79-
# the ME image and part of the coreboot image, and a 4 MB one that
80-
# has the rest of the coreboot and the reset vector.
81-
#
82-
# As a consequence, this replaces the need of having to flash t530-flash
83-
# and expands available CBFS region (11.5Mb available CBFS space)
84-
#
85-
# When flashing via an external programmer it is easiest to have
86-
# two separate files for these pieces.
87-
all: $(board_build)/$(CB_OUTPUT_FILE)
88-
@sha256sum $@ | tee -a "$(HASHES)"
89-
90-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom
91-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom: $(board_build)/$(CB_OUTPUT_FILE)
92-
$(call do,DD 8MB,$@,dd of=$@ if=$< bs=65536 count=128 skip=0 status=none)
93-
@sha256sum $@ | tee -a "$(HASHES)"
9477

95-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom
96-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom: $(board_build)/$(CB_OUTPUT_FILE)
97-
$(call do,DD 4MB,$@,dd of=$@ if=$< bs=65536 count=64 skip=128 status=none)
98-
@sha256sum $@ | tee -a "$(HASHES)"
78+
# Generate split 4MB top / 8MB bottom ROMs
79+
BOARD_TARGETS := split_8mb4mb

boards/UNTESTED_t530-hotp-maximized/UNTESTED_t530-hotp-maximized.config

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -74,25 +74,6 @@ export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
7474
# reduced IFD ME region and expanded BIOS IFD region.
7575
# - blobs/xx30/extract.sh
7676
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
#
78-
# This board has two SPI flash chips, an 8 MB that holds the IFD,
79-
# the ME image and part of the coreboot image, and a 4 MB one that
80-
# has the rest of the coreboot and the reset vector.
81-
#
82-
# As a consequence, this replaces the need of having to flash t530-flash
83-
# and expands available CBFS region (11.5Mb available CBFS space)
84-
#
85-
# When flashing via an external programmer it is easiest to have
86-
# two separate files for these pieces.
87-
all: $(board_build)/$(CB_OUTPUT_FILE)
88-
@sha256sum $@ | tee -a "$(HASHES)"
89-
90-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom
91-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom: $(board_build)/$(CB_OUTPUT_FILE)
92-
$(call do,DD 8MB,$@,dd of=$@ if=$< bs=65536 count=128 skip=0 status=none)
93-
@sha256sum $@ | tee -a "$(HASHES)"
9477

95-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom
96-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom: $(board_build)/$(CB_OUTPUT_FILE)
97-
$(call do,DD 4MB,$@,dd of=$@ if=$< bs=65536 count=64 skip=128 status=none)
98-
@sha256sum $@ | tee -a "$(HASHES)"
78+
# Generate split 4MB top / 8MB bottom ROMs
79+
BOARD_TARGETS := split_8mb4mb

boards/UNTESTED_t530-maximized/UNTESTED_t530-maximized.config

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -74,25 +74,6 @@ export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
7474
# reduced IFD ME region and expanded BIOS IFD region.
7575
# - blobs/xx30/extract.sh
7676
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
#
78-
# This board has two SPI flash chips, an 8 MB that holds the IFD,
79-
# the ME image and part of the coreboot image, and a 4 MB one that
80-
# has the rest of the coreboot and the reset vector.
81-
#
82-
# As a consequence, this replaces the need of having to flash t530-flash
83-
# and expands available CBFS region (11.5Mb available CBFS space)
84-
#
85-
# When flashing via an external programmer it is easiest to have
86-
# two separate files for these pieces.
87-
all: $(board_build)/$(CB_OUTPUT_FILE)
88-
@sha256sum $@ | tee -a "$(HASHES)"
89-
90-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom
91-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom: $(board_build)/$(CB_OUTPUT_FILE)
92-
$(call do,DD 8MB,$@,dd of=$@ if=$< bs=65536 count=128 skip=0 status=none)
93-
@sha256sum $@ | tee -a "$(HASHES)"
9477

95-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom
96-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom: $(board_build)/$(CB_OUTPUT_FILE)
97-
$(call do,DD 4MB,$@,dd of=$@ if=$< bs=65536 count=64 skip=128 status=none)
98-
@sha256sum $@ | tee -a "$(HASHES)"
78+
# Generate split 4MB top / 8MB bottom ROMs
79+
BOARD_TARGETS := split_8mb4mb

boards/UNTESTED_w530-dgpu-K1000m-hotp-maximized/UNTESTED_w530-dgpu-K1000m-hotp-maximized.config

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -74,25 +74,6 @@ export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
7474
# reduced IFD ME region and expanded BIOS IFD region.
7575
# - blobs/xx30/extract.sh
7676
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
#
78-
# This board has two SPI flash chips, an 8 MB that holds the IFD,
79-
# the ME image and part of the coreboot image, and a 4 MB one that
80-
# has the rest of the coreboot and the reset vector.
81-
#
82-
# As a consequence, this replaces the need of having to flash t530-flash
83-
# and expands available CBFS region (11.5Mb available CBFS space)
84-
#
85-
# When flashing via an external programmer it is easiest to have
86-
# two separate files for these pieces.
87-
all: $(board_build)/$(CB_OUTPUT_FILE)
88-
@sha256sum $@ | tee -a "$(HASHES)"
89-
90-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom
91-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom: $(board_build)/$(CB_OUTPUT_FILE)
92-
$(call do,DD 8MB,$@,dd of=$@ if=$< bs=65536 count=128 skip=0 status=none)
93-
@sha256sum $@ | tee -a "$(HASHES)"
9477

95-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom
96-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom: $(board_build)/$(CB_OUTPUT_FILE)
97-
$(call do,DD 4MB,$@,dd of=$@ if=$< bs=65536 count=64 skip=128 status=none)
98-
@sha256sum $@ | tee -a "$(HASHES)"
78+
# Generate split 4MB top / 8MB bottom ROMs
79+
BOARD_TARGETS := split_8mb4mb

boards/UNTESTED_w530-dgpu-K1000m-maximized/UNTESTED_w530-dgpu-K1000m-maximized.config

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -74,25 +74,6 @@ export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
7474
# reduced IFD ME region and expanded BIOS IFD region.
7575
# - blobs/xx30/extract.sh
7676
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
#
78-
# This board has two SPI flash chips, an 8 MB that holds the IFD,
79-
# the ME image and part of the coreboot image, and a 4 MB one that
80-
# has the rest of the coreboot and the reset vector.
81-
#
82-
# As a consequence, this replaces the need of having to flash t530-flash
83-
# and expands available CBFS region (11.5Mb available CBFS space)
84-
#
85-
# When flashing via an external programmer it is easiest to have
86-
# two separate files for these pieces.
87-
all: $(board_build)/$(CB_OUTPUT_FILE)
88-
@sha256sum $@ | tee -a "$(HASHES)"
89-
90-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom
91-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom: $(board_build)/$(CB_OUTPUT_FILE)
92-
$(call do,DD 8MB,$@,dd of=$@ if=$< bs=65536 count=128 skip=0 status=none)
93-
@sha256sum $@ | tee -a "$(HASHES)"
9477

95-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom
96-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom: $(board_build)/$(CB_OUTPUT_FILE)
97-
$(call do,DD 4MB,$@,dd of=$@ if=$< bs=65536 count=64 skip=128 status=none)
98-
@sha256sum $@ | tee -a "$(HASHES)"
78+
# Generate split 4MB top / 8MB bottom ROMs
79+
BOARD_TARGETS := split_8mb4mb

boards/UNTESTED_w530-dgpu-K2000m-hotp-maximized/UNTESTED_w530-dgpu-K2000m-hotp-maximized.config

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -74,25 +74,6 @@ export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
7474
# reduced IFD ME region and expanded BIOS IFD region.
7575
# - blobs/xx30/extract.sh
7676
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
#
78-
# This board has two SPI flash chips, an 8 MB that holds the IFD,
79-
# the ME image and part of the coreboot image, and a 4 MB one that
80-
# has the rest of the coreboot and the reset vector.
81-
#
82-
# As a consequence, this replaces the need of having to flash t530-flash
83-
# and expands available CBFS region (11.5Mb available CBFS space)
84-
#
85-
# When flashing via an external programmer it is easiest to have
86-
# two separate files for these pieces.
87-
all: $(board_build)/$(CB_OUTPUT_FILE)
88-
@sha256sum $@ | tee -a "$(HASHES)"
89-
90-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom
91-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom: $(board_build)/$(CB_OUTPUT_FILE)
92-
$(call do,DD 8MB,$@,dd of=$@ if=$< bs=65536 count=128 skip=0 status=none)
93-
@sha256sum $@ | tee -a "$(HASHES)"
9477

95-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom
96-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom: $(board_build)/$(CB_OUTPUT_FILE)
97-
$(call do,DD 4MB,$@,dd of=$@ if=$< bs=65536 count=64 skip=128 status=none)
98-
@sha256sum $@ | tee -a "$(HASHES)"
78+
# Generate split 4MB top / 8MB bottom ROMs
79+
BOARD_TARGETS := split_8mb4mb

boards/UNTESTED_w530-dgpu-K2000m-maximized/UNTESTED_w530-dgpu-K2000m-maximized.config

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -74,25 +74,6 @@ export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
7474
# reduced IFD ME region and expanded BIOS IFD region.
7575
# - blobs/xx30/extract.sh
7676
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
#
78-
# This board has two SPI flash chips, an 8 MB that holds the IFD,
79-
# the ME image and part of the coreboot image, and a 4 MB one that
80-
# has the rest of the coreboot and the reset vector.
81-
#
82-
# As a consequence, this replaces the need of having to flash t530-flash
83-
# and expands available CBFS region (11.5Mb available CBFS space)
84-
#
85-
# When flashing via an external programmer it is easiest to have
86-
# two separate files for these pieces.
87-
all: $(board_build)/$(CB_OUTPUT_FILE)
88-
@sha256sum $@ | tee -a "$(HASHES)"
89-
90-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom
91-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom: $(board_build)/$(CB_OUTPUT_FILE)
92-
$(call do,DD 8MB,$@,dd of=$@ if=$< bs=65536 count=128 skip=0 status=none)
93-
@sha256sum $@ | tee -a "$(HASHES)"
9477

95-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom
96-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom: $(board_build)/$(CB_OUTPUT_FILE)
97-
$(call do,DD 4MB,$@,dd of=$@ if=$< bs=65536 count=64 skip=128 status=none)
98-
@sha256sum $@ | tee -a "$(HASHES)"
78+
# Generate split 4MB top / 8MB bottom ROMs
79+
BOARD_TARGETS := split_8mb4mb

boards/UNTESTED_w530-hotp-maximized/UNTESTED_w530-hotp-maximized.config

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -74,25 +74,6 @@ export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
7474
# reduced IFD ME region and expanded BIOS IFD region.
7575
# - blobs/xx30/extract.sh
7676
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
#
78-
# This board has two SPI flash chips, an 8 MB that holds the IFD,
79-
# the ME image and part of the coreboot image, and a 4 MB one that
80-
# has the rest of the coreboot and the reset vector.
81-
#
82-
# As a consequence, this replaces the need of having to flash t530-flash
83-
# and expands available CBFS region (11.5Mb available CBFS space)
84-
#
85-
# When flashing via an external programmer it is easiest to have
86-
# two separate files for these pieces.
87-
all: $(board_build)/$(CB_OUTPUT_FILE)
88-
@sha256sum $@ | tee -a "$(HASHES)"
89-
90-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom
91-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom: $(board_build)/$(CB_OUTPUT_FILE)
92-
$(call do,DD 8MB,$@,dd of=$@ if=$< bs=65536 count=128 skip=0 status=none)
93-
@sha256sum $@ | tee -a "$(HASHES)"
9477

95-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom
96-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom: $(board_build)/$(CB_OUTPUT_FILE)
97-
$(call do,DD 4MB,$@,dd of=$@ if=$< bs=65536 count=64 skip=128 status=none)
98-
@sha256sum $@ | tee -a "$(HASHES)"
78+
# Generate split 4MB top / 8MB bottom ROMs
79+
BOARD_TARGETS := split_8mb4mb

boards/UNTESTED_w530-maximized/UNTESTED_w530-maximized.config

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -74,25 +74,6 @@ export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
7474
# reduced IFD ME region and expanded BIOS IFD region.
7575
# - blobs/xx30/extract.sh
7676
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
#
78-
# This board has two SPI flash chips, an 8 MB that holds the IFD,
79-
# the ME image and part of the coreboot image, and a 4 MB one that
80-
# has the rest of the coreboot and the reset vector.
81-
#
82-
# As a consequence, this replaces the need of having to flash t530-flash
83-
# and expands available CBFS region (11.5Mb available CBFS space)
84-
#
85-
# When flashing via an external programmer it is easiest to have
86-
# two separate files for these pieces.
87-
all: $(board_build)/$(CB_OUTPUT_FILE)
88-
@sha256sum $@ | tee -a "$(HASHES)"
89-
90-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom
91-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom: $(board_build)/$(CB_OUTPUT_FILE)
92-
$(call do,DD 8MB,$@,dd of=$@ if=$< bs=65536 count=128 skip=0 status=none)
93-
@sha256sum $@ | tee -a "$(HASHES)"
9477

95-
all: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom
96-
$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom: $(board_build)/$(CB_OUTPUT_FILE)
97-
$(call do,DD 4MB,$@,dd of=$@ if=$< bs=65536 count=64 skip=128 status=none)
98-
@sha256sum $@ | tee -a "$(HASHES)"
78+
# Generate split 4MB top / 8MB bottom ROMs
79+
BOARD_TARGETS := split_8mb4mb

0 commit comments

Comments
 (0)