Skip to content

Commit 77f9933

Browse files
committed
xx20/xx30 blob based boards: move ME blobs target outside of board configs (targets/xx*_blobs.mk)
Makefile: have inclusion of all defined $BOARD BOARD_TARGETS (me, split_8mb4mb, ...) TODO: VBIOS scripts for W530/T530 need way more work. To be done later. Signed-off-by: Thierry Laurion <insurgo@riseup.net>
1 parent d7c2bda commit 77f9933

File tree

28 files changed

+99
-307
lines changed

28 files changed

+99
-307
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ $(error "Unexpected value of $$(CONFIG_TARGET_ARCH): $(CONFIG_TARGET_ARCH)")
8282
endif
8383

8484
ifneq "$(BOARD_TARGETS)" ""
85-
include targets/$(BOARD_TARGETS).mk
85+
include $(foreach TARGET,$(BOARD_TARGETS),targets/$(TARGET).mk)
8686
endif
8787

8888
# Create directories if they don't already exist

boards/UNTESTED_t520-hotp-maximized/UNTESTED_t520-hotp-maximized.config

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,5 @@ export CONFIG_BOOT_DEV="/dev/sda1"
6363
export CONFIG_BOARD_NAME="ThinkPad T520-hotp-maximized"
6464
export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal:ich_spi_mode=hwseq"
6565

66-
# xx20 boards require of you initially call one of the following to habe gbe.bin ifd.bin and me.bin
67-
# - blobs/xx20/download_parse_me.sh
68-
# To download Lenovo update ME binary, neuter+deactivate ME, produce reduced IFD ME region and expended BIOS IFD region.
69-
70-
# Make the Coreboot build depend on the following 3rd party blobs:
71-
$(build)/coreboot-$(CONFIG_COREBOOT_VERSION)/$(BOARD)/.build: \
72-
$(pwd)/blobs/xx20/me.bin
73-
74-
75-
$(pwd)/blobs/xx20/me.bin:
76-
COREBOOT_DIR="$(build)/$(coreboot_base_dir)" \
77-
$(pwd)/blobs/xx20/download_parse_me.sh
66+
#Include bits related to sandybridge ME blob download/neutering down to BUP
67+
BOARD_TARGETS := xx20_me_blobs

boards/UNTESTED_t520-maximized/UNTESTED_t520-maximized.config

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,5 @@ export CONFIG_BOOT_DEV="/dev/sda1"
6363
export CONFIG_BOARD_NAME="ThinkPad T520-maximized"
6464
export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal:ich_spi_mode=hwseq"
6565

66-
# xx20 boards require of you initially call one of the following to habe gbe.bin ifd.bin and me.bin
67-
# - blobs/xx20/download_parse_me.sh
68-
# To download Lenovo update ME binary, neuter+deactivate ME, produce reduced IFD ME region and expended BIOS IFD region.
69-
70-
# Make the Coreboot build depend on the following 3rd party blobs:
71-
$(build)/coreboot-$(CONFIG_COREBOOT_VERSION)/$(BOARD)/.build: \
72-
$(pwd)/blobs/xx20/me.bin
73-
74-
75-
$(pwd)/blobs/xx20/me.bin:
76-
COREBOOT_DIR="$(build)/$(coreboot_base_dir)" \
77-
$(pwd)/blobs/xx20/download_parse_me.sh
66+
#Include bits related to sandybridge ME blob download/neutering down to BUP
67+
BOARD_TARGETS := xx20_me_blobs

boards/UNTESTED_t530-dgpu-hotp-maximized/UNTESTED_t530-dgpu-hotp-maximized.config

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -67,24 +67,15 @@ export CONFIG_BOOT_DEV="/dev/sda1"
6767
export CONFIG_BOARD_NAME="Thinkpad T530-dgpu-hotp-maximized"
6868
export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
6969

70-
# xx30-*-maximized boards require of you initially call one of the
71-
# following to have gbe.bin ifd.bin and me.bin
72-
# - blobs/xx30/download_clean_me.sh
73-
# To download Lenovo original ME binary, neuter+deactivate ME, produce
74-
# reduced IFD ME region and expanded BIOS IFD region.
75-
# - blobs/xx30/extract.sh
76-
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
7870
# Make the Coreboot build depend on the following 3rd party blobs:
7971
$(build)/coreboot-$(CONFIG_COREBOOT_VERSION)/$(BOARD)/.build: \
8072
$(pwd)/blobs/xx30/me.bin $(pwd)/blobs/xx30/10de,0def.rom $(pwd)/blobs/xx30/8086,0106.rom
8173

82-
$(pwd)/blobs/xx30/me.bin:
83-
COREBOOT_DIR="$(build)/$(coreboot_base_dir)" \
84-
$(pwd)/blobs/xx30/download_clean_me.sh $(pwd)/blobs/xx30
74+
#Include bits related to ivybridge ME blob download/neutering down to BUP+ROMP
75+
BOARD_TARGETS := xx30_me_blobs
8576

8677
$(pwd)/blobs/xx30/10de,0def.rom:
8778
$(pwd)/blobs/xx30/vbios_t530.sh
8879

8980
# Generate split 4MB top / 8MB bottom ROMs
90-
BOARD_TARGETS := split_8mb4mb
81+
BOARD_TARGETS += split_8mb4mb

boards/UNTESTED_t530-dgpu-maximized/UNTESTED_t530-dgpu-maximized.config

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -67,25 +67,15 @@ export CONFIG_BOOT_DEV="/dev/sda1"
6767
export CONFIG_BOARD_NAME="Thinkpad T530-dgpu-maximized"
6868
export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
6969

70-
# xx30-*-maximized boards require of you initially call one of the
71-
# following to have gbe.bin ifd.bin and me.bin
72-
# - blobs/xx30/download_clean_me.sh
73-
# To download Lenovo original ME binary, neuter+deactivate ME, produce
74-
# reduced IFD ME region and expanded BIOS IFD region.
75-
# - blobs/xx30/extract.sh
76-
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
7870
# Make the Coreboot build depend on the following 3rd party blobs:
7971
$(build)/coreboot-$(CONFIG_COREBOOT_VERSION)/$(BOARD)/.build: \
8072
$(pwd)/blobs/xx30/me.bin $(pwd)/blobs/xx30/10de,0def.rom $(pwd)/blobs/xx30/8086,0106.rom
8173

82-
83-
$(pwd)/blobs/xx30/me.bin:
84-
COREBOOT_DIR="$(build)/$(coreboot_base_dir)" \
85-
$(pwd)/blobs/xx30/download_clean_me.sh $(pwd)/blobs/xx30
74+
#Include bits related to ivybridge ME blob download/neutering down to BUP+ROMP
75+
BOARD_TARGETS := xx30_me_blobs
8676

8777
$(pwd)/blobs/xx30/10de,0def.rom:
8878
$(pwd)/blobs/xx30/vbios_t530.sh
8979

9080
# Generate split 4MB top / 8MB bottom ROMs
91-
BOARD_TARGETS := split_8mb4mb
81+
BOARD_TARGETS += split_8mb4mb

boards/UNTESTED_t530-hotp-maximized/UNTESTED_t530-hotp-maximized.config

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -67,22 +67,8 @@ export CONFIG_BOOT_DEV="/dev/sda1"
6767
export CONFIG_BOARD_NAME="Thinkpad T530-hotp-maximized"
6868
export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
6969

70-
# xx30-*-maximized boards require of you initially call one of the
71-
# following to have gbe.bin ifd.bin and me.bin
72-
# - blobs/xx30/download_clean_me.sh
73-
# To download Lenovo original ME binary, neuter+deactivate ME, produce
74-
# reduced IFD ME region and expanded BIOS IFD region.
75-
# - blobs/xx30/extract.sh
76-
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
78-
# Make the Coreboot build depend on the following 3rd party blobs:
79-
$(build)/coreboot-$(CONFIG_COREBOOT_VERSION)/$(BOARD)/.build: \
80-
$(pwd)/blobs/xx30/me.bin
81-
82-
83-
$(pwd)/blobs/xx30/me.bin:
84-
COREBOOT_DIR="$(build)/$(coreboot_base_dir)" \
85-
$(pwd)/blobs/xx30/download_clean_me.sh $(pwd)/blobs/xx30
70+
#Include bits related to ivybridge ME blob download/neutering down to BUP+ROMP
71+
BOARD_TARGETS := xx30_me_blobs
8672

8773
# Generate split 4MB top / 8MB bottom ROMs
88-
BOARD_TARGETS := split_8mb4mb
74+
BOARD_TARGETS += split_8mb4mb

boards/UNTESTED_t530-maximized/UNTESTED_t530-maximized.config

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -67,22 +67,8 @@ export CONFIG_BOOT_DEV="/dev/sda1"
6767
export CONFIG_BOARD_NAME="Thinkpad T530-maximized"
6868
export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
6969

70-
# xx30-*-maximized boards require of you initially call one of the
71-
# following to have gbe.bin ifd.bin and me.bin
72-
# - blobs/xx30/download_clean_me.sh
73-
# To download Lenovo original ME binary, neuter+deactivate ME, produce
74-
# reduced IFD ME region and expanded BIOS IFD region.
75-
# - blobs/xx30/extract.sh
76-
# To extract from backuped 8M (bottom SPI) ME binary, GBE and IFD blobs.
77-
78-
# Make the Coreboot build depend on the following 3rd party blobs:
79-
$(build)/coreboot-$(CONFIG_COREBOOT_VERSION)/$(BOARD)/.build: \
80-
$(pwd)/blobs/xx30/me.bin
81-
82-
83-
$(pwd)/blobs/xx30/me.bin:
84-
COREBOOT_DIR="$(build)/$(coreboot_base_dir)" \
85-
$(pwd)/blobs/xx30/download_clean_me.sh $(pwd)/blobs/xx30
70+
#Include bits related to ivybridge ME blob download/neutering down to BUP+ROMP
71+
BOARD_TARGETS := xx30_me_blobs
8672

8773
# Generate split 4MB top / 8MB bottom ROMs
88-
BOARD_TARGETS := split_8mb4mb
74+
BOARD_TARGETS += split_8mb4mb

boards/UNTESTED_w530-dgpu-K1000m-hotp-maximized/UNTESTED_w530-dgpu-K1000m-hotp-maximized.config

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,11 @@ export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
7979
$(build)/coreboot-$(CONFIG_COREBOOT_VERSION)/$(BOARD)/.build: \
8080
$(pwd)/blobs/xx30/me.bin $(pwd)/blobs/xx30/10de,0ffc.rom $(pwd)/blobs/xx30/8086,0106.rom
8181

82-
83-
$(pwd)/blobs/xx30/me.bin:
84-
COREBOOT_DIR="$(build)/$(coreboot_base_dir)" \
85-
$(pwd)/blobs/xx30/download_clean_me.sh $(pwd)/blobs/xx30
82+
#Include bits related to ivybridge ME blob download/neutering down to BUP+ROMP
83+
BOARD_TARGETS := xx30_me_blobs
8684

8785
$(pwd)/blobs/xx30/10de,0ffc.rom:
8886
$(pwd)/blobs/xx30/vbios_w530.sh
8987

9088
# Generate split 4MB top / 8MB bottom ROMs
91-
BOARD_TARGETS := split_8mb4mb
89+
BOARD_TARGETS += split_8mb4mb

boards/UNTESTED_w530-dgpu-K1000m-maximized/UNTESTED_w530-dgpu-K1000m-maximized.config

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,11 @@ export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
7979
$(build)/coreboot-$(CONFIG_COREBOOT_VERSION)/$(BOARD)/.build: \
8080
$(pwd)/blobs/xx30/me.bin $(pwd)/blobs/xx30/10de,0ffc.rom $(pwd)/blobs/xx30/8086,0106.rom
8181

82-
83-
$(pwd)/blobs/xx30/me.bin:
84-
COREBOOT_DIR="$(build)/$(coreboot_base_dir)" \
85-
$(pwd)/blobs/xx30/download_clean_me.sh $(pwd)/blobs/xx30
82+
#Include bits related to ivybridge ME blob download/neutering down to BUP+ROMP
83+
BOARD_TARGETS := xx30_me_blobs
8684

8785
$(pwd)/blobs/xx30/10de,0ffc.rom:
8886
$(pwd)/blobs/xx30/vbios_w530.sh
8987

9088
# Generate split 4MB top / 8MB bottom ROMs
91-
BOARD_TARGETS := split_8mb4mb
89+
BOARD_TARGETS += split_8mb4mb

boards/UNTESTED_w530-dgpu-K2000m-hotp-maximized/UNTESTED_w530-dgpu-K2000m-hotp-maximized.config

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,11 @@ export CONFIG_FLASHROM_OPTIONS="--force --noverify-all -p internal"
7979
$(build)/coreboot-$(CONFIG_COREBOOT_VERSION)/$(BOARD)/.build: \
8080
$(pwd)/blobs/xx30/me.bin $(pwd)/blobs/xx30/10de,0ffb.rom $(pwd)/blobs/xx30/8086,0106.rom
8181

82-
83-
$(pwd)/blobs/xx30/me.bin:
84-
COREBOOT_DIR="$(build)/$(coreboot_base_dir)" \
85-
$(pwd)/blobs/xx30/download_clean_me.sh $(pwd)/blobs/xx30
82+
#Include bits related to ivybridge ME blob download/neutering down to BUP+ROMP
83+
BOARD_TARGETS := xx30_me_blobs
8684

8785
$(pwd)/blobs/xx30/10de,0ffb.rom:
8886
$(pwd)/blobs/xx30/vbios_w530.sh
8987

9088
# Generate split 4MB top / 8MB bottom ROMs
91-
BOARD_TARGETS := split_8mb4mb
89+
BOARD_TARGETS += split_8mb4mb

0 commit comments

Comments
 (0)