Skip to content

Conversation

xjezda00
Copy link
Contributor

@xjezda00 xjezda00 commented Aug 12, 2025

Use _default SELinux level, role, type and user when copy into /etc/selinux/config for ensuring that file has proper SELinux context.

Enhancement:

Reason:
Solves AVCs after tests_selinux_disabled.yml is executed

Result:
No AVCs

Issue Tracker Tickets (Jira or BZ if any):

Summary by Sourcery

Restore /etc/selinux/config in test playbooks with default SELinux context to prevent AVC denials

Bug Fixes:

  • Eliminate AVC errors in selinux_disabled tests by ensuring correct file context

Enhancements:

  • Add selevel, serole, setype, and seuser parameters to copy tasks in selinux test playbooks

Use _default SELinux level, role, type and user when
copy into /etc/selinux/config for ensuring that file
has proper SELinux context.

Signed-off-by: David Jez <djez@redhat.com>
Copy link

sourcery-ai bot commented Aug 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates test playbooks to include default SELinux context attributes (level, role, type, user) in copy tasks for /etc/selinux/config, ensuring the file retains proper SELinux context and eliminating AVC errors.

File-Level Changes

Change Details Files
Add default SELinux context parameters to copy tasks for /etc/selinux/config
  • Add selevel: _default
  • Add serole: _default
  • Add setype: _default
  • Add seuser: _default
tests/tests_selinux_disabled.yml
tests/selinux_config_restore.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xjezda00 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@spetrosi
Copy link
Contributor

[citest]

@milosmalik
Copy link

Looks good to me 👍

@richm richm merged commit 907fbcd into linux-system-roles:main Aug 12, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants