Skip to content

Commit ccd3811

Browse files
KanjiMonsterSasha Levin
authored andcommitted
net: dsa: b53: always rejoin default untagged VLAN on bridge leave
[ Upstream commit 13b152a ] While JOIN_ALL_VLAN allows to join all VLANs, we still need to keep the default VLAN enabled so that untagged traffic stays untagged. So rejoin the default VLAN even for switches with JOIN_ALL_VLAN support. Fixes: 48aea33 ("net: dsa: b53: Add JOIN_ALL_VLAN support") Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> Tested-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Link: https://patch.msgid.link/20250429201710.330937-7-jonas.gorski@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 2a7d846 commit ccd3811

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/net/dsa/b53/b53_common.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2022,12 +2022,12 @@ void b53_br_leave(struct dsa_switch *ds, int port, struct dsa_bridge bridge)
20222022
if (!(reg & BIT(cpu_port)))
20232023
reg |= BIT(cpu_port);
20242024
b53_write16(dev, B53_VLAN_PAGE, B53_JOIN_ALL_VLAN_EN, reg);
2025-
} else {
2026-
b53_get_vlan_entry(dev, pvid, vl);
2027-
vl->members |= BIT(port) | BIT(cpu_port);
2028-
vl->untag |= BIT(port) | BIT(cpu_port);
2029-
b53_set_vlan_entry(dev, pvid, vl);
20302025
}
2026+
2027+
b53_get_vlan_entry(dev, pvid, vl);
2028+
vl->members |= BIT(port) | BIT(cpu_port);
2029+
vl->untag |= BIT(port) | BIT(cpu_port);
2030+
b53_set_vlan_entry(dev, pvid, vl);
20312031
}
20322032
EXPORT_SYMBOL(b53_br_leave);
20332033

0 commit comments

Comments
 (0)