Skip to content

Commit 5e5ddff

Browse files
wedsonafSasha Levin
authored andcommitted
rust: kernel: require Send for Module implementations
[ Upstream commit 323617f ] The thread that calls the module initialisation code when a module is loaded is not guaranteed [in fact, it is unlikely] to be the same one that calls the module cleanup code on module unload, therefore, `Module` implementations must be `Send` to account for them moving from one thread to another implicitly. Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com> Reviewed-by: Alice Ryhl <aliceryhl@google.com> Reviewed-by: Benno Lossin <benno.lossin@proton.me> Cc: stable@vger.kernel.org # 6.8.x: df70d04: rust: phy: implement `Send` for `Registration` Cc: stable@vger.kernel.org Fixes: 247b365 ("rust: add `kernel` crate") Link: https://lore.kernel.org/r/20240328195457.225001-3-wedsonaf@gmail.com Signed-off-by: Miguel Ojeda <ojeda@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent a79b1b6 commit 5e5ddff

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

rust/kernel/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ const __LOG_PREFIX: &[u8] = b"rust_kernel\0";
3737
/// The top level entrypoint to implementing a kernel module.
3838
///
3939
/// For any teardown or cleanup operations, your type may implement [`Drop`].
40-
pub trait Module: Sized + Sync {
40+
pub trait Module: Sized + Sync + Send {
4141
/// Called at module initialization time.
4242
///
4343
/// Use this method to perform whatever setup or registration your module

0 commit comments

Comments
 (0)