fix review comments

Author: rahulait

cloud/linode/loadbalancers.go

@@ -61,7 +61,7 @@ var (
 		string(linodego.AlgorithmRingHash):   true,
 		string(linodego.AlgorithmLeastConn):  true,
 	}
-	// validTCPStickiness is a map of valid HTTP stickiness options
+	// validHTTPStickiness is a map of valid HTTP stickiness options
 	validHTTPStickiness = map[string]bool{
 		string(linodego.StickinessNone):       true,
 		string(linodego.StickinessHTTPCookie): true,

cloud/linode/loadbalancers_helpers.go

@@ -11,6 +11,12 @@ import (
 	"github.com/linode/linode-cloud-controller-manager/cloud/annotations"
 )
 
+const (
+	udpCheckPortDefault = 80
+	udpCheckPortMin     = 1
+	udpCheckPortMax     = 65535
+)
+
 // getPortProtocol returns the protocol for a given service port.
 // It checks the portConfigAnnotationResult for a specific port.
 // If not found, it checks the service annotations for the service.
@@ -94,7 +100,7 @@ func getPortAlgorithm(portConfigAnnotationResult portConfigAnnotation, service *
 // If not found, it checks the service annotations for the service.
 // It also validates the UDP check port against a range of valid ports (1-65535).
 func getPortUDPCheckPort(portConfigAnnotationResult portConfigAnnotation, service *v1.Service, protocol linodego.ConfigProtocol) (int, error) {
-	udpCheckPort := 80
+	udpCheckPort := udpCheckPortDefault
 	if protocol != linodego.ProtocolUDP {
 		return udpCheckPort, nil
 	}
@@ -114,7 +120,7 @@ func getPortUDPCheckPort(portConfigAnnotationResult portConfigAnnotation, servic
 	}
 
 	// Validate the UDP check port to be between 1 and 65535
-	if udpCheckPort < 1 || udpCheckPort > 65535 {
+	if udpCheckPort < udpCheckPortMin || udpCheckPort > udpCheckPortMax {
 		return udpCheckPort, fmt.Errorf("UDPCheckPort must be between 1 and 65535, got %d", udpCheckPort)
 	}
 	return udpCheckPort, nil

docs/configuration/annotations.md

@@ -21,8 +21,8 @@ The keys and the values in [annotations must be strings](https://kubernetes.io/d
 | `throttle` | `0`-`20` (`0` to disable) | `0` | Client Connection Throttle, which limits the number of subsequent new connections per second from the same client IP |
 | `default-protocol` | `tcp`, `udp`, `http`, `https` | `tcp` | This annotation is used to specify the default protocol for Linode NodeBalancer |
 | `default-proxy-protocol` | `none`, `v1`, `v2` | `none` | Specifies whether to use a version of Proxy Protocol on the underlying NodeBalancer |
-| `default-algorithm` | `roundrobin`, `leastconn`, `source`, `ring_hash` | `roundrobin` | This annotation is used to specify the default alogrithm for Linode NodeBalancer |
-| `default-stickiness` | `none`, `session`, `table`, `http_cookie`, `source_ip` | `session` UDP, `table` HTTP/HTTPs | This annotation is used to specify the default stickiness for Linode NodeBalancer |
+| `default-algorithm` | `roundrobin`, `leastconn`, `source`, `ring_hash` | `roundrobin` | This annotation is used to specify the default algorithm for Linode NodeBalancer |
+| `default-stickiness` | `none`, `session`, `table`, `http_cookie`, `source_ip` | `session` (for UDP), `table` (for HTTP/HTTPs) | This annotation is used to specify the default stickiness for Linode NodeBalancer |
 | `port-*` | json object | | Specifies port specific NodeBalancer configuration. See [Port Configuration](#port-specific-configuration) |
 | `check-type` | `none`, `connection`, `http`, `http_body` | `none` for UDP, else `connection` | The type of health check to perform against back-ends. See [Health Checks](loadbalancer.md#health-checks) |
 | `check-path` | string | | The URL path to check on each back-end during health checks |
@@ -57,7 +57,7 @@ metadata:
         "tls-secret-name": "my-tls-secret",
         "proxy-protocol": "v2",
         "algorithm": "leastconn",
-        "stickiness": "http_cookie",
+        "stickiness": "http_cookie"
       }
 ```
 

e2e/test/lb-with-udp-ports/chainsaw-test.yaml

@@ -55,8 +55,8 @@ spec:
                   port_7070_timeout=$(echo $nbconfig | jq '.check_timeout == 3')
                   port_7070_attempts=$(echo $nbconfig | jq '.check_attempts == 2')
                   port_7070_protocol=$(echo $nbconfig | jq '.protocol == "udp"')
-                  #port_7070_up_nodes=$(echo $nbconfig | jq '(.nodes_status.up)|tonumber >= 2')
-                  # Placeholder for the actual check until we have the support
+                  # TODO: Implement the actual check for UDP node health when support is added
+                  # port_7070_up_nodes=$(echo $nbconfig | jq '(.nodes_status.up)|tonumber >= 2')
                   port_7070_up_nodes="true"
 
                   if [[ $port_7070_check == "true" && $port_7070_interval == "true" && $port_7070_timeout == "true" && $port_7070_attempts == "true" && $port_7070_protocol == "true" && $port_7070_up_nodes == "true" ]]; then