add more logging for NB creation errors (#691)

Author: AshleyDumaine

cloud/services/loadbalancers.go

@@ -313,6 +313,7 @@ func AddNodesToNB(ctx context.Context, logger logr.Logger, clusterScope *scope.C
 			// Look for internal IPs that are NOT linode private IPs (likely VPC IPs)
 			if IPs.Type == v1beta1.MachineInternalIP && !util.IsLinodePrivateIP(IPs.Address) {
 				if err := processAndCreateNodeBalancerNodes(ctx, IPs.Address, clusterScope, nodeBalancerNodes, subnetID); err != nil {
+					logger.Error(err, "Failed to process and create NB nodes")
 					return err
 				}
 				return nil // Return early if we found and used a VPC IP
@@ -330,6 +331,7 @@ func AddNodesToNB(ctx context.Context, logger logr.Logger, clusterScope *scope.C
 
 		err := processAndCreateNodeBalancerNodes(ctx, IPs.Address, clusterScope, nodeBalancerNodes, subnetID)
 		if err != nil {
+			logger.Error(err, "Failed to process and create NB nodes")
 			return err
 		}
 		break // Use the first matching IP

internal/controller/linodecluster_controller_helpers.go

@@ -29,6 +29,7 @@ func addMachineToLB(ctx context.Context, clusterScope *scope.ClusterScope) error
 	}
 	if clusterScope.LinodeCluster.Spec.Network.LoadBalancerType == "dns" {
 		if err := services.EnsureDNSEntries(ctx, clusterScope, "create"); err != nil {
+			logger.Error(err, "Failed to ensure DNS entries")
 			return err
 		}
 		return nil
@@ -46,18 +47,21 @@ func addMachineToLB(ctx context.Context, clusterScope *scope.ClusterScope) error
 		&linodego.ListOptions{},
 	)
 	if err != nil {
+		logger.Error(err, "Failed to list NB nodes")
 		return err
 	}
 	for _, eachMachine := range clusterScope.LinodeMachines.Items {
 		err = services.AddNodesToNB(ctx, logger, clusterScope, eachMachine, nodeBalancerNodes)
 		if err != nil {
+			logger.Error(err, "Failed to add nodes to NB")
 			return err
 		}
 	}
 	ipPortCombo := getIPPortCombo(clusterScope)
 	for _, node := range nodeBalancerNodes {
 		if !slices.Contains(ipPortCombo, node.Address) {
 			if err := clusterScope.LinodeClient.DeleteNodeBalancerNode(ctx, node.NodeBalancerID, node.ConfigID, node.ID); err != nil {
+				logger.Error(err, "Failed to delete NB node")
 				return err
 			}
 		}