feat: allow users to define empty env values in builds (#606)

* feat: allow users to define empty env values in builds

* fix: improve extra arguments error display

* fix: extra arguments value label

Author: ferruhcihan

src/pages/builds/create-edit/create-edit.validator.ts

@@ -3,8 +3,8 @@ import { array, boolean, mixed, object, string } from 'yup'
 const envVarSchema = object({
   name: string()
     .required('Environment variable name is required')
-    .matches(/^[a-zA-Z_][a-zA-Z0-9_]*$/, 'Invalid environment variable name'),
-  value: string().required('Environment variable value is required'),
+    .matches(/^-*[a-zA-Z_][a-zA-Z0-9_-]*$/, 'Invalid environment variable name'),
+  value: string().optional(),
 })
 
 const commonModeSchema = object({

src/pages/builds/create-edit/index.tsx

@@ -150,6 +150,15 @@ export default function CreateEditBuilds({
     }
   }
 
+  const extraArgumentsError = () => {
+    const envVarErrors = errors?.mode?.[`${watch('mode.type')}`]?.envVars
+    if (!envVarErrors) return undefined
+    const idx = envVarErrors.findIndex((envVar) => envVar?.name?.message)
+    if (idx === -1) return undefined
+    const message = envVarErrors[idx]?.name?.message?.toString()
+    return `Error in argument ${Number(idx) + 1}: ${message}`
+  }
+
   if (isLoading || isError || (buildName && !watch('name')))
     return <PaperLayout loading title={t('TITLE_CONTAINER_IMAGE')} />
 
@@ -304,11 +313,12 @@ export default function CreateEditBuilds({
                 title='Extra arguments'
                 subTitle='Additional arguments to pass on to the build executor'
                 keyLabel='Name'
-                valueLabel='Value'
+                valueLabel='Value (optional)'
                 addLabel='Add argument'
                 compressed
                 name={`mode.${watch('mode.type')}.envVars`}
                 {...register(`mode.${watch('mode.type')}.envVars`)}
+                errorText={extraArgumentsError()}
               />
 
               <Divider sx={{ mt: 2, mb: 2 }} />