Skip to content

Commit 9f5a6cc

Browse files
authored
fix(inbound): correct error message when transport header is missing (#3724)
The RefusedNoTarget error type is a remnant of an older version of the direct stack. This commit updates the error message to reflect the current state of the code: we require ALPN-negotiated transport headers on all direct connections.
1 parent c87d202 commit 9f5a6cc

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

linkerd/app/inbound/src/direct.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ struct RefusedNoHeader;
2525
pub struct RefusedNoIdentity(());
2626

2727
#[derive(Debug, Error)]
28-
#[error("a named target must be provided on gateway connections")]
29-
struct RefusedNoTarget;
28+
#[error("direct connections require transport header negotiation")]
29+
struct TransportHeaderRequired(());
3030

3131
#[derive(Debug, Clone)]
3232
pub(crate) struct LocalTcp {
@@ -222,7 +222,7 @@ impl<N> Inbound<N> {
222222
if client.header_negotiated() {
223223
Ok(client)
224224
} else {
225-
Err(RefusedNoTarget.into())
225+
Err(TransportHeaderRequired(()).into())
226226
}
227227
})
228228
.push(svc::ArcNewService::layer())

0 commit comments

Comments
 (0)