Skip to content

Commit 37c0f96

Browse files
authored
nit(app): consolidate impl Config blocks (#3919)
this is a trivial, cosmetic change. `Config` has two consecutive `impl` blocks in the `linkerd-app` library. these do not include distinct generics or trait bounds, so the methods contained therein do not need to live in two distinct `impl` blocks. this commit consolidates these blocks. while we are performing this change, we add two `=== impl T ===` banners, which are used throughout the project as greppable strings to find methods and trait implementations for a given type. Signed-off-by: katelyn martin <kate@buoyant.io>
1 parent 79e1077 commit 37c0f96

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

linkerd/app/src/lib.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,13 +83,13 @@ pub struct App {
8383
tap: tap::Tap,
8484
}
8585

86+
// === impl Config ===
87+
8688
impl Config {
8789
pub fn try_from_env() -> Result<Self, env::EnvError> {
8890
env::Env.try_config()
8991
}
90-
}
9192

92-
impl Config {
9393
/// Build an application.
9494
///
9595
/// It is currently required that this be run on a Tokio runtime, since some
@@ -358,6 +358,8 @@ impl Config {
358358
}
359359
}
360360

361+
// === impl App ===
362+
361363
impl App {
362364
pub fn admin_addr(&self) -> Local<ServerAddr> {
363365
self.admin.listen_addr

0 commit comments

Comments
 (0)