Skip to content

Commit 114ee8d

Browse files
authored
fix(just): make dev versions semver (#3719)
Our build can occaisionally fail when the sha is not a valid semver label: --- stdout cargo:rustc-env=GIT_SHA=025979070 cargo:rustc-env=LINKERD2_PROXY_BUILD_DATE=2025-03-08T16:32:34Z --- stderr thread 'main' panicked at linkerd/app/core/build.rs:18:17: LINKERD2_PROXY_VERSION must be semver: version='0.0.0-dev.025979070' error='invalid leading zero in pre-release identifier' To fix this, the dot is removed so the version string is 0.0.0-dev025979070, which is valid.
1 parent 4f24b84 commit 114ee8d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

justfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ toolchain := ""
1515

1616
features := ""
1717

18-
export LINKERD2_PROXY_VERSION := env_var_or_default("LINKERD2_PROXY_VERSION", "0.0.0-dev." + `git rev-parse --short HEAD`)
18+
export LINKERD2_PROXY_VERSION := env_var_or_default("LINKERD2_PROXY_VERSION", "0.0.0-dev" + `git rev-parse --short HEAD`)
1919
export LINKERD2_PROXY_VENDOR := env_var_or_default("LINKERD2_PROXY_VENDOR", `whoami` + "@" + `hostname`)
2020

2121
# The version name to use for packages.

0 commit comments

Comments
 (0)