Skip to content

Commit e3d1704

Browse files
author
Whitney Deng
committed
add STORE_NOMINATED_FOR_SCHEDULED_COMPACTION metric entity
1 parent ebc0e00 commit e3d1704

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

internal/venice-client-common/src/main/java/com/linkedin/venice/stats/metrics/MetricType.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,10 @@ public enum MetricType {
2626
/**
2727
* For Counter: A simple counter that can be added to.
2828
*/
29-
COUNTER;
29+
COUNTER,
30+
31+
/**
32+
* For UpDownCounter: A counter that can be added to or subtracted from. Emits the absolute value of the metric value.
33+
*/
34+
GAUGE;
3035
}

services/venice-controller/src/main/java/com/linkedin/venice/controller/stats/ControllerMetricEntity.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,13 @@ public enum ControllerMetricEntity {
1717
REPUSH_STORE_ENDPOINT_CALL_COUNT(
1818
MetricType.COUNTER, MetricUnit.NUMBER, "Count of all calls to a controller endpoint",
1919
setOf(VENICE_STORE_NAME, VENICE_CLUSTER_NAME, REPUSH_STORE_TRIGGER_SOURCE, VENICE_RESPONSE_STATUS_CODE_CATEGORY)
20-
);
20+
),
21+
STORE_NOMINATED_FOR_SCHEDULED_COMPACTION(
22+
MetricType.GAUGE, MetricUnit.NUMBER,
23+
"When a store is nominated for scheduled compaction and remains uncompacted, this metric will be at 1."
24+
+ " When the store is compacted, this metric will return to 0.",
25+
setOf(VENICE_STORE_NAME, VENICE_CLUSTER_NAME)
26+
),;
2127

2228
private final MetricEntity metricEntity;
2329
private final String metricName;

0 commit comments

Comments
 (0)