-
Notifications
You must be signed in to change notification settings - Fork 31
add the open api execute command #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This repository primarily exists to convert publicly available LINE APIs into OpenAPI YAML, making it easier for developers to access the features. Therefore, it is not intended for open contributions by editing files in this repository, from outside contributors. Please start by creating an issue and discussing it there. You may close this pull request and create an issue instead. == |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@4geru Thank you for your excellent suggestion and pull request!
For this kind of use, using docker-compose would be simpler, as it eliminates the dependency on Make. What do you think?
@mokuzon I created the docker-compose.yml 🤝 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my late.
LGTM with a nits.
- PORT=8080 | ||
- API_URL=/openapi/messaging-api.yml | ||
volumes: | ||
- ./:/usr/share/nginx/html/openapi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits: Please add a line break at the end of the file.
First, make sure you have `docker-compose.yml` in this directory. Then run: | ||
|
||
```sh | ||
docker-compose up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use Docker Compose V2.
|
||
### Using Docker Command | ||
|
||
Alternatively, you can use the following Docker command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
following Docker command
is missing.
@@ -0,0 +1,12 @@ | |||
version: '3.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Docker Compose V2, it is obsolete.
This pull request was closed because it has been inactive for 14 days. Please reopen if you still intend to submit this pull request, or submit issues at first. |
Docker is a helpful tool for developers.
However, this repository doesn't have a manual to stand up Docker.
Therefore, I added the Docker command to the Makefile and README.md.