Skip to content

add the open api execute command #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

4geru
Copy link
Contributor

@4geru 4geru commented Jun 10, 2025

Docker is a helpful tool for developers.
However, this repository doesn't have a manual to stand up Docker.
Therefore, I added the Docker command to the Makefile and README.md.

Copy link

⚠️ Attention @4geru!
Thank you for your interest in contributing to this repository!

This repository primarily exists to convert publicly available LINE APIs into OpenAPI YAML, making it easier for developers to access the features.
Our employees mainly update the schema based on the latest features and changes in our APIs.

Therefore, it is not intended for open contributions by editing files in this repository, from outside contributors.

Please start by creating an issue and discussing it there. You may close this pull request and create an issue instead.

==
If you are an employee participating in this organization, please push branches directly to this repository to create PR, instead of using a forked repository.

Copy link
Contributor

@mokuzon mokuzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@4geru Thank you for your excellent suggestion and pull request!
For this kind of use, using docker-compose would be simpler, as it eliminates the dependency on Make. What do you think?

@Yang-33
Copy link
Contributor

Yang-33 commented Jun 17, 2025

#55

@4geru
Copy link
Contributor Author

4geru commented Jun 19, 2025

@mokuzon I created the docker-compose.yml 🤝

Copy link
Contributor

@mokuzon mokuzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late.
LGTM with a nits.

- PORT=8080
- API_URL=/openapi/messaging-api.yml
volumes:
- ./:/usr/share/nginx/html/openapi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: Please add a line break at the end of the file.

First, make sure you have `docker-compose.yml` in this directory. Then run:

```sh
docker-compose up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use Docker Compose V2.


### Using Docker Command

Alternatively, you can use the following Docker command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following Docker command is missing.

@@ -0,0 +1,12 @@
version: '3.8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Docker Compose V2, it is obsolete.

Copy link

This pull request was closed because it has been inactive for 14 days. Please reopen if you still intend to submit this pull request, or submit issues at first.

@github-actions github-actions bot closed this Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants