Merge pull request #73 from line/feature/rubocop

Add Rubocop and fix related code

Author: kimoto

.rubocop.yml

@@ -0,0 +1,74 @@
+AllCops:
+  TargetRubyVersion: 2.1
+  Exclude:
+    - 'examples/**/*'
+
+Gemspec/RequiredRubyVersion:
+  Enabled: false
+
+Style/TrailingCommaInHashLiteral:
+  Enabled: false
+Style/TrailingCommaInArrayLiteral:
+  Enabled: false
+Style/WordArray:
+  Enabled: false
+Style/NumericLiterals:
+  Enabled: false
+Style/BlockDelimiters:
+  Enabled: false
+Style/MutableConstant:
+  Enabled: false
+Style/StringLiterals:
+  Enabled: false
+Style/RaiseArgs:
+  Enabled: false
+Style/PercentLiteralDelimiters:
+  Enabled: false
+Style/NumericPredicate:
+  Enabled: false
+Style/Documentation:
+  Enabled: false
+Style/IfUnlessModifier:
+  Enabled: false
+Style/Semicolon:
+  Enabled: false
+Style/EachWithObject:
+  Enabled: false
+
+Naming/HeredocDelimiterNaming:
+  Enabled: false
+Naming/UncommunicativeMethodParamName:
+  Enabled: false
+Naming/ConstantName:
+  Enabled: false
+Naming/AccessorMethodName:
+  Enabled: false
+Naming/MethodName:
+  Enabled: false
+
+Metrics/LineLength:
+  Max: 200
+Metrics/BlockLength:
+  Enabled: false
+Metrics/MethodLength:
+  Enabled: false
+Metrics/ClassLength:
+  Enabled: false
+
+Layout/SpaceInsideBlockBraces:
+  Enabled: false
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: false
+Layout/IndentHeredoc:
+  Enabled: false
+Layout/ExtraSpacing:
+  Enabled: false
+Layout/SpaceAroundOperators:
+  Enabled: false
+
+Lint/UnusedBlockArgument:
+  Enabled: false
+Lint/DuplicateMethods:
+  Enabled: false
+Lint/UselessAssignment:
+  Enabled: false

.travis.yml

@@ -7,3 +7,6 @@ rvm:
   - ruby-head
 before_install:
   - gem install bundler
+script:
+  - bundle exec rubocop
+  - bundle exec rspec

Gemfile

@@ -1,3 +1,8 @@
 source 'https://rubygems.org'
 
 gemspec
+
+group :development, :test do
+  # ref: http://docs.rubocop.org/en/latest/installation/
+  gem 'rubocop', '~> 0.56.0', require: false
+end

Rakefile

@@ -3,4 +3,4 @@ require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

lib/line/bot/client.rb

@@ -21,7 +21,6 @@
 module Line
   module Bot
     class Client
-
       #  @return [String]
       attr_accessor :channel_token, :channel_secret, :endpoint
 
@@ -204,7 +203,7 @@ def get_room_member_profile(room_id, user_id)
       #                                   (next property to be included in the response)
       #
       # @return [Net::HTTPResponse]
-      def get_group_member_ids(group_id, continuation_token=nil)
+      def get_group_member_ids(group_id, continuation_token = nil)
         endpoint_path  = "/bot/group/#{group_id}/members/ids"
         endpoint_path += "?start=#{continuation_token}" if continuation_token
         get(endpoint_path)
@@ -217,7 +216,7 @@ def get_group_member_ids(group_id, continuation_token=nil)
       #                                   (next property to be included in the response)
       #
       # @return [Net::HTTPResponse]
-      def get_room_member_ids(room_id, continuation_token=nil)
+      def get_room_member_ids(room_id, continuation_token = nil)
         endpoint_path  = "/bot/room/#{room_id}/members/ids"
         endpoint_path += "?start=#{continuation_token}" if continuation_token
         get(endpoint_path)
@@ -393,16 +392,17 @@ def parse_events_from(request_body)
       # @param channel_signature [String] Request'header 'X-LINE-Signature' # HTTP_X_LINE_SIGNATURE
       #
       # @return [Boolean]
-      def validate_signature(content = "", channel_signature)
+      def validate_signature(content, channel_signature)
         return false if !channel_signature || !channel_secret
 
-        hash = OpenSSL::HMAC::digest(OpenSSL::Digest::SHA256.new, channel_secret, content)
+        hash = OpenSSL::HMAC.digest(OpenSSL::Digest::SHA256.new, channel_secret, content)
         signature = Base64.strict_encode64(hash)
 
         variable_secure_compare(channel_signature, signature)
       end
 
-    private
+      private
+
       # Constant time string comparison.
       #
       # via timing attacks.
@@ -423,6 +423,5 @@ def secure_compare(a, b)
         res == 0
       end
     end
-
   end
 end

lib/line/bot/event/base.rb

@@ -23,7 +23,6 @@ def initialize(src)
         def [](key)
           @src[key]
         end
-
       end
     end
   end

lib/line/bot/event/message.rb

@@ -28,11 +28,9 @@ module MessageType
 
       class Message < Base
         def type
-          begin
-            Line::Bot::Event::MessageType.const_get(@src['message']['type'].capitalize)
-          rescue NameError => e
-            Line::Bot::Event::MessageType::Unsupport
-          end
+          Line::Bot::Event::MessageType.const_get(@src['message']['type'].capitalize)
+        rescue NameError => e
+          Line::Bot::Event::MessageType::Unsupport
         end
 
         def message

lib/line/bot/httpclient.rb

@@ -20,7 +20,6 @@
 module Line
   module Bot
     class HTTPClient
-
       # @return [Net::HTTP]
       def http(uri)
         http = Net::HTTP.new(uri.host, uri.port)

lib/line/bot/request.rb

@@ -39,7 +39,7 @@ def payload
           messages: messages
         }
 
-        payload.delete_if{|k, v| v.nil?}.to_json
+        payload.delete_if { |k, v| v.nil? }.to_json
       end
 
       # @return [Hash]

line-bot-api.gemspec

@@ -1,5 +1,4 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'line/bot/api/version'
 
@@ -20,9 +19,9 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version     = '>= 2.0.0'
 
-  spec.add_development_dependency 'rake', "~> 10.4"
-  spec.add_development_dependency "bundler", "~> 1.11"
-  spec.add_development_dependency "webmock", "~> 1.24"
   spec.add_development_dependency "addressable", "~> 2.3"
+  spec.add_development_dependency "bundler", "~> 1.11"
+  spec.add_development_dependency 'rake', "~> 10.4"
   spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "webmock", "~> 1.24"
 end