Skip to content

Commit 1da3d4c

Browse files
authored
Allow renovate PR to have un committed changes (#630)
I've found CI always fails when renovate updates git submodule... If there is un-committed changes by renovate PR(= new code will be generated by openapi generator), I think we can allow this. Finally github actions open PR after the PR by renovate is merged. Another way is to make renovate to run script to generate code again, but the cost is a little bit high.(https://docs.renovatebot.com/configuration-options/#postupgradetasks) The situation won't get bad even when we merge this change, so let me merge this change.
1 parent 15b5512 commit 1da3d4c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/php-checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454
diff=$(git --no-pager diff --name-only HEAD)
5555
echo "DIFF_IS_EMPTY=$([[ -z "$diff" ]] && echo 'true' || echo 'false')" >> $GITHUB_ENV
5656
echo "CURRENT_DATETIME=$(date +'%Y%m%d%H%M%S')" >> $GITHUB_ENV
57-
- if: ${{ env.DIFF_IS_EMPTY != 'true' }}
57+
- if: ${{ env.DIFF_IS_EMPTY != 'true' && github.actor != 'renovate[bot]' }}
5858
run: |
5959
echo "There are changes from the auto-generated files by OAS. Please run diff-check.yml and merge the PR generated by it first."
6060
exit 1

0 commit comments

Comments
 (0)