Skip to content

Commit d59538e

Browse files
authored
OAuth API v2.1 endpoint change (#233)
1 parent a7349db commit d59538e

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

lib/client.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import {
1313
MESSAGING_API_PREFIX,
1414
DATA_API_PREFIX,
1515
OAUTH_BASE_PREFIX,
16+
OAUTH_BASE_PREFIX_V2_1,
1617
} from "./endpoints";
1718

1819
export default class Client {
@@ -618,7 +619,7 @@ export class OAuth {
618619
public issueChannelAccessTokenV2_1(
619620
client_assertion: string,
620621
): Promise<Types.ChannelAccessToken> {
621-
return this.http.postForm(`${OAUTH_BASE_PREFIX}/v2.1/token`, {
622+
return this.http.postForm(`${OAUTH_BASE_PREFIX_V2_1}/token`, {
622623
grant_type: "client_credentials",
623624
client_assertion_type:
624625
"urn:ietf:params:oauth:client-assertion-type:jwt-bearer",
@@ -629,7 +630,7 @@ export class OAuth {
629630
public getIssuedChannelAccessTokenV2_1(
630631
client_assertion: string,
631632
): Promise<{ access_tokens: string[] }> {
632-
return this.http.get(`${OAUTH_BASE_PREFIX}/v2.1/tokens`, {
633+
return this.http.get(`${OAUTH_BASE_PREFIX_V2_1}/tokens`, {
633634
client_assertion_type:
634635
"urn:ietf:params:oauth:client-assertion-type:jwt-bearer",
635636
client_assertion,
@@ -641,7 +642,7 @@ export class OAuth {
641642
client_secret: string,
642643
access_token: string,
643644
): Promise<{}> {
644-
return this.http.postForm(`${OAUTH_BASE_PREFIX}/v2.1/revoke`, {
645+
return this.http.postForm(`${OAUTH_BASE_PREFIX_V2_1}/revoke`, {
645646
client_id,
646647
client_secret,
647648
access_token,

lib/endpoints.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
export const MESSAGING_API_PREFIX = `https://api.line.me/v2/bot`;
22
export const DATA_API_PREFIX = `https://api-data.line.me/v2/bot`;
33
export const OAUTH_BASE_PREFIX = `https://api.line.me/v2/oauth`;
4+
export const OAUTH_BASE_PREFIX_V2_1 = `https://api.line.me/oauth2/v2.1`;

test/client.spec.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import * as nock from "nock";
99
import {
1010
MESSAGING_API_PREFIX,
1111
OAUTH_BASE_PREFIX,
12+
OAUTH_BASE_PREFIX_V2_1,
1213
DATA_API_PREFIX,
1314
} from "../lib/endpoints";
1415

@@ -944,8 +945,8 @@ describe("oauth", () => {
944945
it("issueChannelAccessTokenV2_1", async () => {
945946
const client_assertion = "client_assertion";
946947

947-
const scope = nock(OAUTH_BASE_PREFIX, interceptionOption)
948-
.post("/v2.1/token", {
948+
const scope = nock(OAUTH_BASE_PREFIX_V2_1, interceptionOption)
949+
.post("/token", {
949950
grant_type: "client_credentials",
950951
client_assertion_type:
951952
"urn:ietf:params:oauth:client-assertion-type:jwt-bearer",
@@ -964,8 +965,8 @@ describe("oauth", () => {
964965
access_tokens: ["test_access_tokens"],
965966
};
966967

967-
const scope = nock(OAUTH_BASE_PREFIX)
968-
.get("/v2.1/tokens")
968+
const scope = nock(OAUTH_BASE_PREFIX_V2_1)
969+
.get("/tokens")
969970
.query({
970971
client_assertion_type:
971972
"urn:ietf:params:oauth:client-assertion-type:jwt-bearer",
@@ -982,8 +983,8 @@ describe("oauth", () => {
982983
const client_id = "test_client_id",
983984
client_secret = "test_client_secret",
984985
access_token = "test_channel_access_token";
985-
const scope = nock(OAUTH_BASE_PREFIX, interceptionOption)
986-
.post("/v2.1/revoke", { client_id, client_secret, access_token })
986+
const scope = nock(OAUTH_BASE_PREFIX_V2_1, interceptionOption)
987+
.post("/revoke", { client_id, client_secret, access_token })
987988
.reply(200, {});
988989

989990
const res = await oauth.revokeChannelAccessTokenV2_1(

0 commit comments

Comments
 (0)