Skip to content

Commit c54185d

Browse files
author
Hyunje Jun
committed
Fix misimplemented 'unlinkRichMenuFromUser' client API
Resolve #59. 'unlinkRichMenuFromUser' URI shouldn't include richmenu ID.
1 parent 9b6b7b5 commit c54185d

File tree

2 files changed

+9
-14
lines changed

2 files changed

+9
-14
lines changed

lib/client.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,8 @@ export default class Client {
143143
return this.post(URL.userRichMenu(userId, richMenuId));
144144
}
145145

146-
public unlinkRichMenuFromUser(
147-
userId: string,
148-
richMenuId: string,
149-
): Promise<any> {
150-
return this.delete(URL.userRichMenu(userId, richMenuId));
146+
public unlinkRichMenuFromUser(userId: string): Promise<any> {
147+
return this.delete(URL.userRichMenu(userId));
151148
}
152149

153150
public getRichMenuImage(richMenuId: string): Promise<Readable> {

test/client.spec.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -248,15 +248,13 @@ describe("client", () => {
248248
});
249249

250250
it("unlinkRichMenuFromUser", () => {
251-
return client
252-
.unlinkRichMenuFromUser("test_user_id", "test_rich_menu_id")
253-
.then((res: any) => {
254-
const req = getRecentReq();
255-
equal(req.headers.authorization, "Bearer test_channel_access_token");
256-
equal(req.path, "/user/test_user_id/richmenu/test_rich_menu_id");
257-
equal(req.method, "DELETE");
258-
deepEqual(res, {});
259-
});
251+
return client.unlinkRichMenuFromUser("test_user_id").then((res: any) => {
252+
const req = getRecentReq();
253+
equal(req.headers.authorization, "Bearer test_channel_access_token");
254+
equal(req.path, "/user/test_user_id/richmenu");
255+
equal(req.method, "DELETE");
256+
deepEqual(res, {});
257+
});
260258
});
261259

262260
it("setRichMenuImage", () => {

0 commit comments

Comments
 (0)