Merge pull request #26 from musou1500/fix-middleware-signature-validation

fix signature validation

Author: Hyunje Jun

lib/exceptions.ts

@@ -1,7 +1,7 @@
 export class SignatureValidationFailed extends Error {
   constructor(
     message: string,
-    public signature: string,
+    public signature?: string,
   ) {
     super(message);
   }

lib/middleware.ts

@@ -22,7 +22,7 @@ export default function middleware(config: Line.Config & Line.MiddlewareConfig):
     const signature = req.headers["x-line-signature"] as string;
 
     if (!signature) {
-      next();
+      next(new SignatureValidationFailed("no signature"));
       return;
     }
 

test/middleware.spec.ts

@@ -72,4 +72,18 @@ describe("middleware", () => {
         equal(err.statusCode, 400);
       });
   });
+
+  it("fails on empty signature", () => {
+    return post(`${TEST_URL}/webhook`, {}, { events: [webhook] })
+      .then((res: any) => {
+        throw new Error();
+      })
+      .catch((err: any) => {
+        if (err instanceof HTTPError) {
+          equal(err.statusCode, 401);
+        } else {
+          throw err;
+        }
+      });
+  });
 });