Skip to content

Replace custom netty event loop metrics with micrometer provided metrics #6274

@divijvaidya

Description

@divijvaidya

We have added a few Netty event loop related metrics at #4675, because at that time micrometer did not support these metrics. Since then micrometer >= 1.11 version supports similar metrics but under a different namespace - micrometer-metrics/micrometer#522.

The namespace of the metrics differ in the two implementations. Hence, we will need to deprecate the old metrics (but not remove them to keep backward compatibility) and add the new ones. The table below highlights the changes in the metric names.

Metric purpose Micrometer (micrometer-metrics/micrometer#522) Armeria (#4675)
Pending I/O tasks waiting on an EventLoop netty.eventexecutor.tasks.pending <prefix>.event.loop.pending.tasks (e.g. armeria.netty.common.event.loop.pending.tasks)
Number of EventLoop threads in a group (not exported) (started a request to add this at micrometer-metrics/micrometer#6375) <prefix>.event.loop.workers
Netty allocator / memory-usage gauges netty.allocator.* (memory.used, memory.pinned, pooled.*) Added in 7a6ddd7

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions