debug phpstan

use non-dist

Author: limenet

.github/workflows/phpstan.yml

@@ -22,5 +22,8 @@ jobs:
       - name: Install composer dependencies
         uses: ramsey/composer-install@v3
 
+      - name: Show PHPStan diagnose
+        run: ./vendor/bin/phpstan diagnose
+
       - name: Run PHPStan
         run: ./vendor/bin/phpstan --error-format=github

.gitignore

@@ -4,8 +4,6 @@ build
 composer.lock
 coverage
 docs
-phpunit.xml
-phpstan.neon
 testbench.yaml
 vendor
 node_modules

composer.json

@@ -28,6 +28,7 @@
         "nunomaduro/collision": "^8.6.1",
         "orchestra/testbench": "^9.11 || ^10.1",
         "phpstan/extension-installer": "^1.4.3",
+        "phpstan/phpstan": "^2.1.8",
         "phpstan/phpstan-deprecation-rules": "^2.0.1",
         "phpstan/phpstan-phpunit": "^2.0.4",
         "phpstan/phpstan-strict-rules": "^2.0.3",

phpstan.neon.dist renamed to phpstan.neon

@@ -23,7 +23,9 @@ public function __construct(
 
     public function handle(): int
     {
-        if (! $this->option('force') && ! $this->confirm('Do you want to proceed? (y/N)', false)) {
+        /** @var bool $force */
+        $force = $this->option('force');
+        if (! $force && ! $this->confirm('Do you want to proceed? (y/N)', false)) {
             return self::SUCCESS;
         }
 

phpunit.xml.dist renamed to phpunit.xml

@@ -25,10 +25,12 @@ public function __construct(
 
     public function handle(): int
     {
+        /** @var array<int,string> $indices */
+        $indices = $this->argument('index');
         foreach ($this->indexRepository->all() as $indexConfig) {
             if (
-                ! empty($this->argument('index'))
-                && ! in_array($indexConfig->getName(), $this->argument('index'), true)
+                ! empty($indices)
+                && ! in_array($indexConfig->getName(), $indices, true)
             ) {
                 continue;
             }
@@ -37,7 +39,9 @@ public function handle(): int
 
             $lock = $indexConfig->indexingLock();
 
-            if ($this->option('force')) {
+            /** @var bool $force */
+            $force = $this->option('force');
+            if ($force) {
                 $lock->forceRelease();
             }
 
@@ -49,9 +53,12 @@ public function handle(): int
 
             $indexConfigKey = $indexConfig::class;
 
+            /** @var bool $delete */
+            $delete = $this->option('delete');
+
             Bus::batch([
                 [
-                    new SetupIndex($indexConfigKey, $this->option('delete')),
+                    new SetupIndex($indexConfigKey, $delete),
                     new PopulateIndex($indexConfigKey),
                 ],
             ])