improve phpstan

Author: limenet

composer.json

@@ -30,6 +30,7 @@
         "phpstan/extension-installer": "^1.2",
         "phpstan/phpstan-deprecation-rules": "^1.1.3",
         "phpstan/phpstan-phpunit": "^1.3.10",
+        "phpstan/phpstan-strict-rules": "^1.5",
         "phpunit/phpunit": "^10.0.18",
         "rector/rector": "^0.15.23"
     },

phpstan-baseline.neon

@@ -1,5 +1,20 @@
 parameters:
 	ignoreErrors:
+		-
+			message: "#^Only booleans are allowed in a negated boolean, array\\|bool\\|string\\|null given\\.$#"
+			count: 1
+			path: src/Commands/DeleteCommand.php
+
+		-
+			message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
+			count: 1
+			path: src/Commands/IndexCommand.php
+
+		-
+			message: "#^Only booleans are allowed in a negated boolean, mixed given\\.$#"
+			count: 1
+			path: src/Commands/IndexCommand.php
+
 		-
 			message: "#^Parameter \\#2 \\$haystack of function in_array expects array, array\\|string\\|true given\\.$#"
 			count: 1
@@ -20,6 +35,41 @@ parameters:
 			count: 1
 			path: src/Index/AbstractIndex.php
 
+		-
+			message: "#^Casting to string something that's already string\\.$#"
+			count: 1
+			path: src/Index/AbstractIndex.php
+
+		-
+			message: "#^Method Limenet\\\\LaravelElasticaBridge\\\\Index\\\\AbstractIndex\\:\\:getCreateArguments\\(\\) return type has no value type specified in iterable type array\\.$#"
+			count: 1
+			path: src/Index/AbstractIndex.php
+
+		-
+			message: "#^Method Limenet\\\\LaravelElasticaBridge\\\\Index\\\\AbstractIndex\\:\\:getMapping\\(\\) return type has no value type specified in iterable type array\\.$#"
+			count: 1
+			path: src/Index/AbstractIndex.php
+
+		-
+			message: "#^Method Limenet\\\\LaravelElasticaBridge\\\\Index\\\\AbstractIndex\\:\\:getSettings\\(\\) return type has no value type specified in iterable type array\\.$#"
+			count: 1
+			path: src/Index/AbstractIndex.php
+
+		-
+			message: "#^Method Limenet\\\\LaravelElasticaBridge\\\\Index\\\\IndexInterface\\:\\:getCreateArguments\\(\\) return type has no value type specified in iterable type array\\.$#"
+			count: 1
+			path: src/Index/IndexInterface.php
+
+		-
+			message: "#^Method Limenet\\\\LaravelElasticaBridge\\\\Index\\\\IndexInterface\\:\\:getMapping\\(\\) return type has no value type specified in iterable type array\\.$#"
+			count: 1
+			path: src/Index/IndexInterface.php
+
+		-
+			message: "#^Method Limenet\\\\LaravelElasticaBridge\\\\Index\\\\IndexInterface\\:\\:getSettings\\(\\) return type has no value type specified in iterable type array\\.$#"
+			count: 1
+			path: src/Index/IndexInterface.php
+
 		-
 			message: "#^Cannot access offset 'events' on Illuminate\\\\Contracts\\\\Foundation\\\\Application\\.$#"
 			count: 1

phpstan.neon.dist

@@ -10,5 +10,5 @@ parameters:
     tmpDir: build/phpstan
     checkOctaneCompatibility: true
     checkModelProperties: true
-    checkMissingIterableValueType: false
+    checkMissingIterableValueType: true
 

src/Commands/DeleteCommand.php

@@ -45,6 +45,9 @@ public function handle(): int
         return self::SUCCESS;
     }
 
+    /**
+     * @return string[]
+     */
     private function inidices(): array
     {
         $indices = [];

src/Jobs/AbstractIndexJob.php

@@ -27,6 +27,9 @@ public function uniqueId(): string
         return $this->indexConfig::class;
     }
 
+    /**
+     * @return array<int,object>
+     */
     public function middleware(): array
     {
         return [

src/Jobs/PopulateBatchIndex.php

@@ -34,7 +34,7 @@ public function __construct(
 
     public function handle(): void
     {
-        if ($this->batch()?->cancelled()) {
+        if ($this->batch()?->cancelled() === true) {
             return;
         }
 

src/Jobs/PopulateIndex.php

@@ -18,7 +18,7 @@ public function __construct(
 
     public function handle(): void
     {
-        if ($this->batch()?->cancelled()) {
+        if ($this->batch()?->cancelled() === true) {
             return;
         }
 

src/Jobs/SetupIndex.php

@@ -24,7 +24,7 @@ public function __construct(
 
     public function handle(ElasticaClient $elastica): void
     {
-        if ($this->batch()?->cancelled()) {
+        if ($this->batch()?->cancelled() === true) {
             return;
         }
         $this->migrate($elastica);

src/Model/ElasticsearchableInterface.php

@@ -14,6 +14,9 @@ interface ElasticsearchableInterface
      */
     public function getElasticsearchId(): string;
 
+    /**
+     * @return array<int|string,mixed>
+     */
     public function toElasticsearch(IndexInterface $indexConfig): array;
 
     public function shouldIndex(IndexInterface $indexConfig): bool;

src/Repository/IndexRepository.php

@@ -13,8 +13,14 @@
  */
 class IndexRepository
 {
+    /**
+     * @var array<class-string<IndexInterface>,IndexInterface>
+     */
     private array $indices;
 
+    /**
+     * @param  IndexInterface[]  $indices
+     */
     public function __construct(array $indices)
     {
         foreach ($indices as $index) {
@@ -23,13 +29,16 @@ public function __construct(array $indices)
     }
 
     /**
-     * @return array<string,IndexInterface>
+     * @return array<class-string<IndexInterface>,IndexInterface>
      */
     public function all(): array
     {
         return $this->indices;
     }
 
+    /**
+     * @param  class-string<IndexInterface>  $key
+     */
     public function get(string $key): IndexInterface
     {
         return $this->indices[$key];