cleanup

Author: limenet

CHANGELOG.md

@@ -4,7 +4,9 @@ All notable changes to `laravel-elastica-bridge` will be documented in this file
 
 ## 1.1.0 - UNRELEASED
 
-- provide default implementation for `Limenet\LaravelElasticaBridge\Model\ElasticsearchableInterface\toElasticsearch`
+- provide default implementation for `Limenet\LaravelElasticaBridge\Model\ElasticsearchableInterface::toElasticsearch()` in `ElasticsearchableTrait`
+- provide default implementation for `Limenet\LaravelElasticaBridge\Model\ElasticsearchableInterface::shouldIndex()` in `ElasticsearchableTrait`
+- remove unused method `Limenet\LaravelElasticaBridge\Model\ElasticsearchableInterface::getModel()`
 - added tests
 
 ## 1.0.0 - 2021-05-09

src/Model/ElasticsearchableInterface.php

@@ -9,8 +9,6 @@
 
 interface ElasticsearchableInterface
 {
-    public function getModel(): string;
-
     /**
      * @internal
      */

src/Model/ElasticsearchableTrait.php

@@ -9,11 +9,6 @@
 
 trait ElasticsearchableTrait
 {
-    final public function getModel(): string
-    {
-        return __CLASS__;
-    }
-
     final public function getElasticsearchId(): string
     {
         return $this::class.'|'.$this->id;
@@ -23,6 +18,11 @@ public function toElasticsearch(IndexInterface $indexConfig): array
         return $this->toArray();
     }
 
+    public function shouldIndex(IndexInterface $indexConfig): bool
+    {
+        return true;
+    }
+
     public function toElasticaDocument(IndexInterface $indexConfig): Document
     {
         return new Document(

tests/App/Models/Product.php

@@ -15,11 +15,6 @@ class Product extends Model implements ElasticsearchableInterface
     use HasFactory;
     use ElasticsearchableTrait;
 
-    public function shouldIndex(IndexInterface $indexConfig): bool
-    {
-        return true;
-    }
-
     protected static function newFactory(): Factory
     {
         return ProductFactory::new();