-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Description
While attempting to import the <Dropdown> component from Flame in the new insights app, we ran into a Typescript issue where the app wouldn't compile because children is not a valid prop in the Dropdown interface.
The insights app is using React 18 and in that version React.FC no longer includes children by default.
So any Flame components that
- use
React.FC - include a
childrenprop - don't type their props to include
childrenor extend a type that does so (e.g.Box)
will probably need to be updated to be compatible with React 18 and TS.
Requirements
Dependencies
<Dropdown> and other similar components that take children can be successfully used in a React 18 / Typescript project, like lighthouse-insights.
Required before signoff
n/a
Design/Examples
n/a
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request