Skip to content

Commit a67df68

Browse files
committed
.github: ignore Send coverage errors
Sometimes only the "Send coverage" step of a CI job will fail. This commit turns this step into a "best effort" step instead so that it does not block a CI job from passing. It can, for example, often happen that a single job is re-run from the GH UI, it then passes but the "Send coverage" step fails due to the "Can't add a job to a build that is already closed." error meaning that the only way to get the CI step to pass is to re-push and retrigger a full CI run.
1 parent 4dbbd83 commit a67df68

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ jobs:
262262
- name: Send coverage
263263
uses: ziggie1984/actions-goveralls@c440f43938a4032b627d2b03d61d4ae1a2ba2b5c
264264
if: matrix.unit_type == 'btcd unit-cover'
265+
continue-on-error: true
265266
with:
266267
path-to-profile: coverage.txt
267268
flag-name: 'unit'
@@ -315,6 +316,7 @@ jobs:
315316

316317
- name: Send coverage
317318
if: ${{ contains(matrix.args, 'cover=1') }}
319+
continue-on-error: true
318320
uses: ziggie1984/actions-goveralls@c440f43938a4032b627d2b03d61d4ae1a2ba2b5c
319321
with:
320322
path-to-profile: coverage.txt
@@ -382,6 +384,7 @@ jobs:
382384

383385
- name: Send coverage
384386
if: ${{ contains(matrix.args, 'cover=1') }}
387+
continue-on-error: true
385388
uses: shogo82148/actions-goveralls@v1
386389
with:
387390
path-to-profile: coverage.txt

0 commit comments

Comments
 (0)