Merge pull request #9512 from Roasbeef/go-1-23

multi: update build system to Go 1.23

Author: Roasbeef

.github/workflows/main.yml

@@ -34,7 +34,7 @@ env:
 
   # If you change this please also update GO_VERSION in Makefile (then run
   # `make lint` to see where else it needs to be updated as well).
-  GO_VERSION: 1.22.11
+  GO_VERSION: 1.23.6
 
 jobs:
   ########################

.github/workflows/release.yaml

@@ -12,7 +12,7 @@ defaults:
 env:
   # If you change this please also update GO_VERSION in Makefile (then run
   # `make lint` to see where else it needs to be updated as well).
-  GO_VERSION: 1.22.11
+  GO_VERSION: 1.23.6
 
 jobs:
   main:

.golangci.yml

@@ -1,7 +1,7 @@
 run:
   # If you change this please also update GO_VERSION in Makefile (then run
   # `make lint` to see where else it needs to be updated as well).
-  go: "1.22.11"
+  go: "1.23.6"
 
   # Abort after 10 minutes.
   timeout: 10m
@@ -38,10 +38,6 @@ linters-settings:
     # Check for incorrect fmt.Errorf error wrapping.
     errorf: true
 
-  govet:
-    # Don't report about shadowed variables
-    check-shadowing: false
-
   gofmt:
     # simplify code: gofmt with `-s` option, true by default
     simplify: true
@@ -60,6 +56,7 @@ linters-settings:
       - G402 # Look for bad TLS connection settings.
       - G306 # Poor file permissions used when writing to a new file.
       - G601 # Implicit memory aliasing in for loop.
+      - G115 # Integer overflow in conversion.
 
   staticcheck:
     checks: ["-SA1019"]
@@ -151,9 +148,7 @@ linters:
     - gofumpt
 
     # Disable whitespace linter as it has conflict rules against our
-    # contribution guidelines. See https://github.com/bombsimon/wsl/issues/109.
-    #
-    # TODO(yy): bring it back when the above issue is fixed.
+    # contribution guidelines.
     - wsl
 
     # Allow using default empty values.
@@ -182,7 +177,7 @@ linters:
     - wrapcheck
 
     # Allow dynamic errors.
-    - goerr113
+    - err113
 
     # We use ErrXXX instead.
     - errname
@@ -197,7 +192,7 @@ linters:
 
     # The linter is too aggressive and doesn't add much value since reviewers
     # will also catch magic numbers that make sense to extract.
-    - gomnd
+    - mnd
 
     # Some of the tests cannot be parallelized. On the other hand, we don't
     # gain much performance with this check so we disable it for now until
@@ -218,16 +213,7 @@ linters:
     - goconst
 
     # Deprecated linters that have been replaced by newer ones.
-    - deadcode
-    - exhaustivestruct
-    - ifshort
-    - golint
-    - interfacer
-    - varcheck
-    - nosnakecase
-    - scopelint
-    - structcheck
-    - maligned
+    - tenv
 
 issues:
   # Only show newly introduced problems.

Dockerfile

@@ -1,6 +1,6 @@
 # If you change this please also update GO_VERSION in Makefile (then run
 # `make lint` to see where else it needs to be updated as well).
-FROM golang:1.22.11-alpine as builder
+FROM golang:1.23.6-alpine as builder
 
 # Force Go to use the cgo based DNS resolver. This is required to ensure DNS
 # queries required to connect to linked containers succeed.

Makefile

@@ -35,7 +35,7 @@ endif
 # GO_VERSION is the Go version used for the release build, docker files, and
 # GitHub Actions. This is the reference version for the project. All other Go
 # versions are checked against this version.
-GO_VERSION = 1.22.11
+GO_VERSION = 1.23.6
 
 GOBUILD := $(LOOPVARFIX) go build -v
 GOINSTALL := $(LOOPVARFIX) go install -v

autopilot/prefattach_test.go

@@ -578,7 +578,7 @@ func newMemChannelGraph() *memChannelGraph {
 // error, then execution should be terminated.
 //
 // NOTE: Part of the autopilot.ChannelGraph interface.
-func (m memChannelGraph) ForEachNode(cb func(Node) error) error {
+func (m *memChannelGraph) ForEachNode(cb func(Node) error) error {
 	for _, node := range m.graph {
 		if err := cb(node); err != nil {
 			return err

dev.Dockerfile

@@ -1,6 +1,6 @@
 # If you change this please also update GO_VERSION in Makefile (then run
 # `make lint` to see where else it needs to be updated as well).
-FROM golang:1.22.11-alpine as builder
+FROM golang:1.23.6-alpine as builder
 
 LABEL maintainer="Olaoluwa Osuntokun <laolu@lightning.engineering>"
 

docker/btcd/Dockerfile

@@ -1,6 +1,6 @@
 # If you change this please also update GO_VERSION in Makefile (then run
 # `make lint` to see where else it needs to be updated as well).
-FROM golang:1.22.11-alpine as builder
+FROM golang:1.23.6-alpine as builder
 
 LABEL maintainer="Olaoluwa Osuntokun <laolu@lightning.engineering>"
 

docs/INSTALL.md

@@ -93,24 +93,24 @@ following build dependencies are required:
 
 ### Installing Go
 
-`lnd` is written in Go, with a minimum version of `1.22.6` (or, in case this
+`lnd` is written in Go, with a minimum version of `1.23.6` (or, in case this
 document gets out of date, whatever the Go version in the main `go.mod` file
 requires). To install, run one of the following commands for your OS:
 
 <details>
   <summary>Linux (x86-64)</summary>
 
   ```
-  wget https://dl.google.com/go/go1.22.6.linux-amd64.tar.gz
-  sha256sum go1.22.6.linux-amd64.tar.gz | awk -F " " '{ print $1 }'
+  wget https://dl.google.com/go/go1.23.6.linux-amd64.tar.gz
+  sha256sum go1.23.6.linux-amd64.tar.gz | awk -F " " '{ print $1 }'
   ```
 
   The final output of the command above should be
-  `999805bed7d9039ec3da1a53bfbcafc13e367da52aa823cb60b68ba22d44c616`. If it
+  `9379441ea310de000f33a4dc767bd966e72ab2826270e038e78b2c53c2e7802d`. If it
   isn't, then the target REPO HAS BEEN MODIFIED, and you shouldn't install
   this version of Go. If it matches, then proceed to install Go:
   ```
-  sudo rm -rf /usr/local/go && sudo tar -C /usr/local -xzf go1.22.6.linux-amd64.tar.gz
+  sudo rm -rf /usr/local/go && sudo tar -C /usr/local -xzf go1.23.6.linux-amd64.tar.gz
   export PATH=$PATH:/usr/local/go/bin
   ```
 </details>
@@ -119,16 +119,16 @@ requires). To install, run one of the following commands for your OS:
   <summary>Linux (ARMv6)</summary>
 
   ```
-  wget https://dl.google.com/go/go1.22.6.linux-armv6l.tar.gz
-  sha256sum go1.22.6.linux-armv6l.tar.gz | awk -F " " '{ print $1 }'
+  wget https://dl.google.com/go/go1.23.6.linux-armv6l.tar.gz
+  sha256sum go1.23.6.linux-armv6l.tar.gz | awk -F " " '{ print $1 }'
   ```
 
   The final output of the command above should be
-  `b566484fe89a54c525dd1a4cbfec903c1f6e8f0b7b3dbaf94c79bc9145391083`. If it
+  `27a4611010c16b8c4f37ade3aada55bd5781998f02f348b164302fd5eea4eb74`. If it
   isn't, then the target REPO HAS BEEN MODIFIED, and you shouldn't install
   this version of Go. If it matches, then proceed to install Go:
   ```
-  sudo rm -rf /usr/local/go && tar -C /usr/local -xzf go1.22.6.linux-armv6l.tar.gz
+  sudo rm -rf /usr/local/go && tar -C /usr/local -xzf go1.23.6.linux-armv6l.tar.gz
   export PATH=$PATH:/usr/local/go/bin
   ```  
 

go.mod

@@ -210,6 +210,6 @@ replace google.golang.org/protobuf => github.com/lightninglabs/protobuf-go-hex-d
 // If you change this please also update docs/INSTALL.md and GO_VERSION in
 // Makefile (then run `make lint` to see where else it needs to be updated as
 // well).
-go 1.22.6
+go 1.23.6
 
 retract v0.0.2

graph/db/graph.go

@@ -733,7 +733,7 @@ func (c *ChannelGraph) ForEachNode(cb func(tx NodeRTx) error) error {
 // early.
 //
 // TODO(roasbeef): add iterator interface to allow for memory efficient graph
-// traversal when graph gets mega
+// traversal when graph gets mega.
 func (c *ChannelGraph) forEachNode(
 	cb func(kvdb.RTx, *models.LightningNode) error) error {
 

invoices/sql_migration_test.go

@@ -43,7 +43,7 @@ func randomStringRapid(t *rapid.T, length int) string {
 }
 
 // randTimeBetween generates a random time between min and max.
-func randTimeBetween(min, max time.Time) time.Time {
+func randTimeBetween(minTime, maxTime time.Time) time.Time {
 	var timeZones = []*time.Location{
 		time.UTC,
 		time.FixedZone("EST", -5*3600),
@@ -53,16 +53,16 @@ func randTimeBetween(min, max time.Time) time.Time {
 	}
 
 	// Ensure max is after min
-	if max.Before(min) {
-		min, max = max, min
+	if maxTime.Before(minTime) {
+		minTime, maxTime = maxTime, minTime
 	}
 
 	// Calculate the range in nanoseconds
-	duration := max.Sub(min)
+	duration := maxTime.Sub(minTime)
 	randDuration := time.Duration(rand.Int63n(duration.Nanoseconds()))
 
 	// Generate the random time
-	randomTime := min.Add(randDuration)
+	randomTime := minTime.Add(randDuration)
 
 	// Assign a random time zone
 	randomTimeZone := timeZones[rand.Intn(len(timeZones))]
@@ -73,10 +73,10 @@ func randTimeBetween(min, max time.Time) time.Time {
 
 // randTime generates a random time between 2009 and 2140.
 func randTime() time.Time {
-	min := time.Date(2009, 1, 3, 0, 0, 0, 0, time.UTC)
-	max := time.Date(2140, 1, 1, 0, 0, 0, 1000, time.UTC)
+	minTime := time.Date(2009, 1, 3, 0, 0, 0, 0, time.UTC)
+	maxTime := time.Date(2140, 1, 1, 0, 0, 0, 1000, time.UTC)
 
-	return randTimeBetween(min, max)
+	return randTimeBetween(minTime, maxTime)
 }
 
 func randInvoiceTime(invoice *Invoice) time.Time {

lnrpc/Dockerfile

@@ -1,6 +1,6 @@
 # If you change this please also update GO_VERSION in Makefile (then run
 # `make lint` to see where else it needs to be updated as well).
-FROM golang:1.22.11-bookworm
+FROM golang:1.23.6-bookworm
 
 RUN apt-get update && apt-get install -y \
   git \

lnrpc/gen_protos_docker.sh

@@ -3,28 +3,28 @@
 set -e
 
 # Directory of the script file, independent of where it's called from.
-DIR="$(cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd)"
+DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # golang docker image version used in this script.
-GO_IMAGE=docker.io/library/golang:1.22.11-alpine
+GO_IMAGE=docker.io/library/golang:1.23.6-alpine
 
 PROTOBUF_VERSION=$(docker run --rm -v $DIR/../:/lnd -w /lnd $GO_IMAGE \
-  go list -f '{{.Version}}' -m google.golang.org/protobuf)
+	go list -f '{{.Version}}' -m google.golang.org/protobuf)
 GRPC_GATEWAY_VERSION=$(docker run --rm -v $DIR/../:/lnd -w /lnd $GO_IMAGE \
-  go list -f '{{.Version}}' -m github.com/grpc-ecosystem/grpc-gateway/v2)
+	go list -f '{{.Version}}' -m github.com/grpc-ecosystem/grpc-gateway/v2)
 
 echo "Building protobuf compiler docker image..."
 docker build -t lnd-protobuf-builder \
-  --build-arg PROTOBUF_VERSION="$PROTOBUF_VERSION" \
-  --build-arg GRPC_GATEWAY_VERSION="$GRPC_GATEWAY_VERSION" \
-  .
+	--build-arg PROTOBUF_VERSION="$PROTOBUF_VERSION" \
+	--build-arg GRPC_GATEWAY_VERSION="$GRPC_GATEWAY_VERSION" \
+	.
 
 echo "Compiling and formatting *.proto files..."
 docker run \
-  --rm \
-  --user "$UID:$(id -g)" \
-  -e UID=$UID \
-  -e COMPILE_MOBILE \
-  -e SUBSERVER_PREFIX \
-  -v "$DIR/../:/build" \
-  lnd-protobuf-builder
+	--rm \
+	--user "$UID:$(id -g)" \
+	-e UID=$UID \
+	-e COMPILE_MOBILE \
+	-e SUBSERVER_PREFIX \
+	-v "$DIR/../:/build" \
+	lnd-protobuf-builder

make/builder.Dockerfile

@@ -1,6 +1,6 @@
 # If you change this please also update GO_VERSION in Makefile (then run
 # `make lint` to see where else it needs to be updated as well).
-FROM golang:1.22.11-bookworm
+FROM golang:1.23.6-bookworm
 
 MAINTAINER Olaoluwa Osuntokun <laolu@lightning.engineering>
 

tools/.custom-gcl.yml

@@ -1,4 +1,4 @@
-version: v1.57.0
+version: v1.64.5
 plugins:
   - module: 'github.com/lightningnetwork/lnd/tools/linters'
     path: ./linters

tools/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.22.11
+FROM golang:1.23.6
 
 RUN apt-get update && apt-get install -y git
 ENV GOCACHE=/tmp/build/.cache