Merge pull request #9798 from ellemouton/graphFixNotificationSubs

graph/db: synchronous topology client subscriptions/cancellations

Author: guggero

docs/release-notes/release-notes-0.19.0.md

@@ -128,6 +128,9 @@ when running LND with an aux component injected (custom channels).
   such that the probability is evaluated quicker and to be more accurate in
   outdated scenarios.
 
+* [Fix a bug](https://github.com/lightningnetwork/lnd/pull/9798) that could
+  result in a new topology client missing a channel-close notifications. 
+
 # New Features
 
 * Add support for [archiving channel backup](https://github.com/lightningnetwork/lnd/pull/9232)

graph/db/graph.go

@@ -492,9 +492,12 @@ func (c *ChannelGraph) PruneGraph(spentOutputs []*wire.OutPoint,
 		closeSummaries := createCloseSummaries(
 			blockHeight, edges...,
 		)
-		c.notifyTopologyChange(&TopologyChange{
-			ClosedChannels: closeSummaries,
-		})
+
+		select {
+		case c.topologyUpdate <- closeSummaries:
+		case <-c.quit:
+			return nil, ErrChanGraphShuttingDown
+		}
 	}
 
 	return edges, nil

graph/db/notifications.go

@@ -149,6 +149,9 @@ type topologyClient struct {
 
 // notifyTopologyChange notifies all registered clients of a new change in
 // graph topology in a non-blocking.
+//
+// NOTE: this should only ever be called from a call-stack originating from the
+// handleTopologySubscriptions handler.
 func (c *ChannelGraph) notifyTopologyChange(topologyDiff *TopologyChange) {
 	// notifyClient is a helper closure that will send topology updates to
 	// the given client.
@@ -194,7 +197,8 @@ func (c *ChannelGraph) notifyTopologyChange(topologyDiff *TopologyChange) {
 // handleTopologyUpdate is responsible for sending any topology changes
 // notifications to registered clients.
 //
-// NOTE: must be run inside goroutine.
+// NOTE: must be run inside goroutine and must only ever be called from within
+// handleTopologySubscriptions.
 func (c *ChannelGraph) handleTopologyUpdate(update any) {
 	defer c.wg.Done()
 
@@ -445,6 +449,10 @@ func (c *ChannelGraph) addToTopologyChange(update *TopologyChange,
 			edgeUpdate)
 		return nil
 
+	case []*ClosedChanSummary:
+		update.ClosedChannels = append(update.ClosedChannels, m...)
+		return nil
+
 	default:
 		return fmt.Errorf("unable to add to topology change, "+
 			"unknown message type %T", msg)