itest: rename helper func LogAndPublish to PublishAndLogTransfer

Renames the helper function to match RPC endpoint name.

Author: ffranr

itest/mint_fund_seal_test.go

@@ -464,7 +464,7 @@ func testMintFundSealAssets(t *harnessTest) {
 
 	// Finalize and publish the transfer anchor TX.
 	signedPkt := FinalizePacket(t.t, aliceLnd.RPC, transferPkt)
-	logResp := LogAndPublish(
+	logResp := PublishAndLogTransfer(
 		t.t, aliceTapd, signedPkt, bobVpsbt, passiveVpsbts,
 		commitResp,
 	)

itest/multi_send_test.go

@@ -374,7 +374,7 @@ func testAnchorMultipleVirtualTransactions(t *harnessTest) {
 
 	btcPacket = signPacket(t.t, aliceLnd, btcPacket)
 	btcPacket = FinalizePacket(t.t, aliceLnd.RPC, btcPacket)
-	sendResp = LogAndPublish(
+	sendResp = PublishAndLogTransfer(
 		t.t, aliceTapd, btcPacket, activeAssets, passiveAssets,
 		commitResp,
 	)

itest/multisig.go

@@ -334,7 +334,7 @@ func MultiSigTest(t *testing.T, ctx context.Context, aliceTapd,
 	// transaction.
 	signedPkt := FinalizePacket(t, bobLnd, btcWithdrawPkt)
 
-	logResp := LogAndPublish(
+	logResp := PublishAndLogTransfer(
 		t, bobTapd, signedPkt, finalizedWithdrawPackets, nil,
 		commitResp,
 	)
@@ -490,11 +490,16 @@ func FinalizePacket(t *testing.T, lnd *rpc.HarnessRPC,
 	return signedPacket
 }
 
-func LogAndPublish(t *testing.T, tapd commands.RpcClientsBundle,
+// PublishAndLogTransfer is a helper function that invokes the
+// PublishAndLogTransfer RPC endpoint on the specified tapd node. This endpoint
+// performs a pre-anchored transfer.
+func PublishAndLogTransfer(t *testing.T, tapd commands.RpcClientsBundle,
 	btcPkt *psbt.Packet, activeAssets []*tappsbt.VPacket,
 	passiveAssets []*tappsbt.VPacket,
 	commitResp *wrpc.CommitVirtualPsbtsResponse) *taprpc.SendAssetResponse {
 
+	t.Helper()
+
 	ctxb := context.Background()
 	ctxt, cancel := context.WithTimeout(ctxb, defaultWaitTimeout)
 	defer cancel()

itest/psbt_test.go

@@ -1124,7 +1124,7 @@ func testPsbtInteractiveAltLeafAnchoring(t *harnessTest) {
 
 	commitPacket = signPacket(t.t, senderLnd, commitPacket)
 	commitPacket = FinalizePacket(t.t, senderLnd.RPC, commitPacket)
-	publishResp := LogAndPublish(
+	publishResp := PublishAndLogTransfer(
 		t.t, sender, commitPacket, []*tappsbt.VPacket{activePacket},
 		[]*tappsbt.VPacket{passivePacket}, commitResp,
 	)
@@ -2438,7 +2438,7 @@ func testPsbtTrustlessSwap(t *harnessTest) {
 	signedPkt := finalizePacket(t.t, lndBob, finalPsbt)
 	require.True(t.t, signedPkt.IsComplete())
 
-	logResp := LogAndPublish(
+	logResp := PublishAndLogTransfer(
 		t.t, alice, signedPkt, []*tappsbt.VPacket{bobVPsbt}, nil, resp,
 	)
 	t.Logf("Logged transaction: %v", toJSON(t.t, logResp))
@@ -2611,7 +2611,7 @@ func testPsbtExternalCommit(t *harnessTest) {
 
 	btcPacket = signPacket(t.t, aliceLnd, btcPacket)
 	btcPacket = FinalizePacket(t.t, aliceLnd.RPC, btcPacket)
-	sendResp := LogAndPublish(
+	sendResp := PublishAndLogTransfer(
 		t.t, aliceTapd, btcPacket, activeAssets, passiveAssets,
 		commitResp,
 	)
@@ -3273,7 +3273,7 @@ func testPsbtRelativeLockTimeSendProofFail(t *harnessTest) {
 		Cancel:            streamCancel,
 	}
 
-	LogAndPublish(t.t, bob, btcPacket, vPackets, nil, commitResp)
+	PublishAndLogTransfer(t.t, bob, btcPacket, vPackets, nil, commitResp)
 
 	MineBlocks(t.t, t.lndHarness.Miner().Client, 1, 1)