Merge pull request #1532 from lightninglabs/1531-sendpayment-fail-fast

guggero · web-flow · commit 8b9cfa0d0e5d · 2025-05-13T17:46:08.000+02:00
rpcserver: stop SendPayment update stream when payment fails
diff --git a/rpcserver.go b/rpcserver.go
@@ -7817,6 +7817,13 @@ func (r *rpcServer) SendPayment(req *tchrpc.SendPaymentRequest,
 		if err != nil {
 			return err
 		}
+
+		// If the payment failed, return an error and stop listening
+		// for updates immediately.
+		if update.Status == lnrpc.Payment_FAILED {
+			return fmt.Errorf("payment failed: %s",
+				update.FailureReason.String())
+		}
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -7817,6 +7817,13 @@ func (r rpcServer) SendPayment(req tchrpc.SendPaymentRequest,`
`7817`	`7817`	`if err != nil {`
`7818`	`7818`	`return err`
`7819`	`7819`	`}`
	`7820`	`+`
	`7821`	`+ // If the payment failed, return an error and stop listening`
	`7822`	`+ // for updates immediately.`
	`7823`	`+ if update.Status == lnrpc.Payment_FAILED {`
	`7824`	`+ return fmt.Errorf("payment failed: %s",`
	`7825`	`+ update.FailureReason.String())`
	`7826`	`+ }`
`7820`	`7827`	`}`
`7821`	`7828`	`}`
`7822`	`7829`