itest: allow AssertNonInteractiveRecvComplete more time to execute

Move the context definition inside the retry loop to create a new
timeout context for each attempt. Double the retry period to allow
multiple retries.

This likely doesn't fully fix the flake, but using the full
defaultWaitTimeout instead of half aligns better with its usage
elsewhere.

Author: ffranr

itest/assertions.go

@@ -1225,13 +1225,13 @@ func AssertAssetOutboundTransferWithOutputs(t *testing.T,
 func AssertNonInteractiveRecvComplete(t *testing.T,
 	receiver taprpc.TaprootAssetsClient, totalInboundTransfers int) {
 
-	ctxb := context.Background()
-	ctxt, cancel := context.WithTimeout(ctxb, defaultWaitTimeout)
-	defer cancel()
-
 	// And finally, they should be marked as completed with a proof
 	// available.
 	err := wait.NoError(func() error {
+		ctxb := context.Background()
+		ctxt, cancel := context.WithTimeout(ctxb, defaultWaitTimeout/2)
+		defer cancel()
+
 		resp, err := receiver.AddrReceives(
 			ctxt, &taprpc.AddrReceivesRequest{},
 		)
@@ -1250,7 +1250,7 @@ func AssertNonInteractiveRecvComplete(t *testing.T,
 		}
 
 		return nil
-	}, defaultWaitTimeout/2)
+	}, defaultWaitTimeout)
 	require.NoError(t, err)
 }