-
Notifications
You must be signed in to change notification settings - Fork 120
Bug / Feature (?) Static Loop in address cannot be filled by lncli closechannel #923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey! Thanks for reporting this! |
Sure thing!
|
Notworthy addition, I haven't tested, but this might be a critical to check upfront whether |
An address imported using ImportTapscript doesn't provide a private key so it can't satisfy waddrmgr.ManagedPubKeyAddress interface. So we don't return an error for imported addresses. Fix lightninglabs/loop#923
I'm working on the fix. Please don't deploy yet. |
An address imported using ImportTapscript doesn't provide a private key so it can't satisfy waddrmgr.ManagedPubKeyAddress interface. So we don't return an error for imported addresses. Fix lightninglabs/loop#923
Safeguard against lightninglabs/loop#923
Safeguard against lightninglabs/loop#923
Safeguard against lightninglabs/loop#923
Make sure that an address imported to LND via ImportTapscript or ImportPublicKey can be used as a delivery address in coop close. New test cases: - P2TR address imported with ImportTapscript - P2TR address imported with ImportPublicKey - P2WPKH address imported with ImportPublicKey Safeguard against lightninglabs/loop#923
An address imported using ImportTapscript doesn't provide a private key so it can't satisfy waddrmgr.ManagedPubKeyAddress interface. So we don't return an error for imported addresses. Fix lightninglabs/loop#923
Make sure that an address imported to LND via ImportTapscript or ImportPublicKey can be used as a delivery address in coop close. New test cases: - P2TR address imported with ImportTapscript - P2TR address imported with ImportPublicKey - P2WPKH address imported with ImportPublicKey Safeguard against lightninglabs/loop#923
An address imported using ImportTapscript doesn't provide a private key so it can't satisfy waddrmgr.ManagedPubKeyAddress interface. So we don't return an error for imported addresses. Fix lightninglabs/loop#923
Make sure that an address imported to LND via ImportTapscript or ImportPublicKey can be used as a delivery address in coop close. New test cases: - P2TR address imported with ImportTapscript - P2TR address imported with ImportPublicKey - P2WPKH address imported with ImportPublicKey Safeguard against lightninglabs/loop#923
Make sure that an address imported to LND via ImportTapscript or ImportPublicKey can be used as a delivery address in coop close. New test cases: - P2TR address imported with ImportTapscript - P2TR address imported with ImportPublicKey - P2WPKH address imported with ImportPublicKey Safeguard against lightninglabs/loop#923
Make sure that an address imported to LND via ImportTapscript or ImportPublicKey can be used as a delivery address in coop close. New test cases: - P2TR address imported with ImportTapscript - P2TR address imported with ImportPublicKey - P2WPKH address imported with ImportPublicKey Safeguard against lightninglabs/loop#923
The fix was just merged to LND master. It is expected to be included to 0.19.0 release. Reopening the issue for now, until it is released and confirmed. |
Tested lnd 0.19.0-beta.rc3. Managed to close a channel to a static address. |
Great, thank you @starius . I'll wait rc3 to mature a little more and try myself, too. |
lncli closechannel --delivery_addr
allows to define an address to send the remaining funds to upon a channel-close.Considered the idea to have my recent channel-close all go to the static loop in address failed, due to the following error:
so apparently lncli errors out because of the defined static delivery address, since it worked without that parameter.
Doublechecked the address twice:
So unsure if it's a bug or a missing feature, however my suggestion would be to ensure that lncli can fill a static loop in address on coop-channel closures.
The text was updated successfully, but these errors were encountered: