Skip to content

Commit 3e3c863

Browse files
committed
loopout: add asset accounting
1 parent dfa58d4 commit 3e3c863

File tree

6 files changed

+920
-682
lines changed

6 files changed

+920
-682
lines changed

client.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,10 @@ func (s *Client) FetchSwaps(ctx context.Context) ([]*SwapInfo, error) {
349349
return nil, swap.ErrInvalidOutputType
350350
}
351351

352+
if swp.Contract.AssetSwapInfo != nil {
353+
swapInfo.AssetSwapInfo = swp.Contract.AssetSwapInfo
354+
}
355+
352356
swaps = append(swaps, swapInfo)
353357
}
354358

loopd/swapclient_server.go

Lines changed: 31 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -309,8 +309,8 @@ func toWalletAddrType(addrType looprpc.AddressType) (walletrpc.AddressType,
309309
}
310310
}
311311

312-
func (s *swapClientServer) marshallSwap(loopSwap *loop.SwapInfo) (
313-
*looprpc.SwapStatus, error) {
312+
func (s *swapClientServer) marshallSwap(ctx context.Context,
313+
loopSwap *loop.SwapInfo) (*looprpc.SwapStatus, error) {
314314

315315
var (
316316
state looprpc.SwapState
@@ -383,6 +383,7 @@ func (s *swapClientServer) marshallSwap(loopSwap *loop.SwapInfo) (
383383
)
384384
var outGoingChanSet []uint64
385385
var lastHop []byte
386+
var assetInfo *looprpc.AssetLoopOutInfo
386387

387388
switch loopSwap.SwapType {
388389
case swap.TypeIn:
@@ -413,6 +414,22 @@ func (s *swapClientServer) marshallSwap(loopSwap *loop.SwapInfo) (
413414

414415
outGoingChanSet = loopSwap.OutgoingChanSet
415416

417+
if loopSwap.AssetSwapInfo != nil {
418+
assetName, err := s.assetClient.GetAssetName(
419+
ctx, loopSwap.AssetSwapInfo.AssetId,
420+
)
421+
if err != nil {
422+
return nil, err
423+
}
424+
425+
assetInfo = &looprpc.AssetLoopOutInfo{
426+
AssetId: hex.EncodeToString(loopSwap.AssetSwapInfo.AssetId), // nolint:lll
427+
AssetCostOffchain: loopSwap.AssetSwapInfo.PrepayPaidAmt +
428+
loopSwap.AssetSwapInfo.SwapPaidAmt, // nolint:lll
429+
AssetName: assetName,
430+
}
431+
}
432+
416433
default:
417434
return nil, errors.New("unknown swap type")
418435
}
@@ -435,6 +452,7 @@ func (s *swapClientServer) marshallSwap(loopSwap *loop.SwapInfo) (
435452
Label: loopSwap.Label,
436453
LastHop: lastHop,
437454
OutgoingChanSet: outGoingChanSet,
455+
AssetInfo: assetInfo,
438456
}, nil
439457
}
440458

@@ -445,7 +463,7 @@ func (s *swapClientServer) Monitor(in *looprpc.MonitorRequest,
445463
log.Infof("Monitor request received")
446464

447465
send := func(info loop.SwapInfo) error {
448-
rpcSwap, err := s.marshallSwap(&info)
466+
rpcSwap, err := s.marshallSwap(server.Context(), &info)
449467
if err != nil {
450468
return err
451469
}
@@ -540,7 +558,7 @@ func (s *swapClientServer) Monitor(in *looprpc.MonitorRequest,
540558

541559
// ListSwaps returns a list of all currently known swaps and their current
542560
// status.
543-
func (s *swapClientServer) ListSwaps(_ context.Context,
561+
func (s *swapClientServer) ListSwaps(ctx context.Context,
544562
req *looprpc.ListSwapsRequest) (*looprpc.ListSwapsResponse, error) {
545563

546564
var (
@@ -563,7 +581,7 @@ func (s *swapClientServer) ListSwaps(_ context.Context,
563581
continue
564582
}
565583

566-
rpcSwap, err := s.marshallSwap(&swp)
584+
rpcSwap, err := s.marshallSwap(ctx, &swp)
567585
if err != nil {
568586
return nil, err
569587
}
@@ -641,11 +659,17 @@ func filterSwap(swapInfo *loop.SwapInfo, filter *looprpc.ListSwapsFilter) bool {
641659
}
642660
}
643661

662+
// If we only want to return asset swaps, we only return swaps that have
663+
// an asset id set.
664+
if filter.AssetSwapOnly && swapInfo.AssetSwapInfo == nil {
665+
return false
666+
}
667+
644668
return true
645669
}
646670

647671
// SwapInfo returns all known details about a single swap.
648-
func (s *swapClientServer) SwapInfo(_ context.Context,
672+
func (s *swapClientServer) SwapInfo(ctx context.Context,
649673
req *looprpc.SwapInfoRequest) (*looprpc.SwapStatus, error) {
650674

651675
swapHash, err := lntypes.MakeHash(req.Id)
@@ -659,7 +683,7 @@ func (s *swapClientServer) SwapInfo(_ context.Context,
659683
if !ok {
660684
return nil, fmt.Errorf("swap with hash %s not found", req.Id)
661685
}
662-
return s.marshallSwap(&swp)
686+
return s.marshallSwap(ctx, &swp)
663687
}
664688

665689
// AbandonSwap requests the server to abandon a swap with the given hash.

loopout.go

Lines changed: 50 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"context"
55
"crypto/rand"
66
"crypto/sha256"
7+
"encoding/json"
78
"errors"
89
"fmt"
910
"math"
@@ -355,6 +356,10 @@ func (s *loopOutSwap) sendUpdate(ctx context.Context) error {
355356
info.OutgoingChanSet = outgoingChanSet
356357
}
357358

359+
if s.isAssetSwap() {
360+
info.AssetSwapInfo = s.AssetSwapInfo
361+
}
362+
358363
select {
359364
case s.statusChan <- *info:
360365
case <-ctx.Done():
@@ -436,7 +441,7 @@ func (s *loopOutSwap) executeAndFinalize(globalCtx context.Context) error {
436441
case result := <-s.swapPaymentChan:
437442
s.swapPaymentChan = nil
438443

439-
err := s.handlePaymentResult(result, true)
444+
err := s.handlePaymentResult(globalCtx, result, true)
440445
if err != nil {
441446
return err
442447
}
@@ -452,7 +457,7 @@ func (s *loopOutSwap) executeAndFinalize(globalCtx context.Context) error {
452457
case result := <-s.prePaymentChan:
453458
s.prePaymentChan = nil
454459

455-
err := s.handlePaymentResult(result, false)
460+
err := s.handlePaymentResult(globalCtx, result, false)
456461
if err != nil {
457462
return err
458463
}
@@ -485,8 +490,8 @@ func (s *loopOutSwap) executeAndFinalize(globalCtx context.Context) error {
485490
// handlePaymentResult processes the result of a payment attempt. If the
486491
// payment was successful and this is the main swap payment, the cost of the
487492
// swap is updated.
488-
func (s *loopOutSwap) handlePaymentResult(result paymentResult,
489-
swapPayment bool) error {
493+
func (s *loopOutSwap) handlePaymentResult(ctx context.Context,
494+
result paymentResult, swapPayment bool) error {
490495

491496
switch {
492497
// If our result has a non-nil error, our status will be nil. In this
@@ -513,6 +518,17 @@ func (s *loopOutSwap) handlePaymentResult(result paymentResult,
513518
// the swap payment and the prepay.
514519
s.cost.Offchain += result.status.Fee.ToSatoshis()
515520

521+
// If this is an asset payment, we'll write the asset amounts
522+
// to the swap.
523+
if s.isAssetSwap() {
524+
err := s.fillAssetOffchainPaymentResult(
525+
ctx, result, swapPayment,
526+
)
527+
if err != nil {
528+
return err
529+
}
530+
}
531+
516532
return nil
517533

518534
case result.status.State == lnrpc.Payment_FAILED:
@@ -1035,7 +1051,7 @@ func (s *loopOutSwap) waitForConfirmedHtlc(globalCtx context.Context) (
10351051
case result := <-s.swapPaymentChan:
10361052
s.swapPaymentChan = nil
10371053

1038-
err := s.handlePaymentResult(result, true)
1054+
err := s.handlePaymentResult(ctx, result, true)
10391055
if err != nil {
10401056
return nil, err
10411057
}
@@ -1057,7 +1073,7 @@ func (s *loopOutSwap) waitForConfirmedHtlc(globalCtx context.Context) (
10571073
case result := <-s.prePaymentChan:
10581074
s.prePaymentChan = nil
10591075

1060-
err := s.handlePaymentResult(result, false)
1076+
err := s.handlePaymentResult(ctx, result, false)
10611077
if err != nil {
10621078
return nil, err
10631079
}
@@ -1458,6 +1474,34 @@ func (s *loopOutSwap) canSweep() bool {
14581474
return true
14591475
}
14601476

1477+
func (s *loopOutSwap) fillAssetOffchainPaymentResult(ctx context.Context,
1478+
result paymentResult, isSwapPayment bool) error {
1479+
1480+
if len(result.status.Htlcs) == 0 {
1481+
return fmt.Errorf("no htlcs in payment result")
1482+
}
1483+
1484+
// We only expect one htlc in the result.
1485+
htlc := result.status.Htlcs[0]
1486+
1487+
var assetData rfqmsg.JsonHtlc
1488+
1489+
err := json.Unmarshal(htlc.Route.CustomChannelData, &assetData)
1490+
if err != nil {
1491+
return err
1492+
}
1493+
1494+
assetSendAmt := assetData.Balances[0].Amount
1495+
if isSwapPayment {
1496+
s.AssetSwapInfo.SwapPaidAmt = assetSendAmt
1497+
log.Debugf("Asset off-chain payment success: %v", assetSendAmt)
1498+
} else {
1499+
s.AssetSwapInfo.PrepayPaidAmt = assetSendAmt
1500+
}
1501+
1502+
return s.store.UpdateLoopOutAssetInfo(ctx, s.hash, s.AssetSwapInfo)
1503+
}
1504+
14611505
// isAssetSwap returns true if the swap is an asset swap.
14621506
func (s *loopOutSwap) isAssetSwap() bool {
14631507
return s.AssetSwapInfo != nil

0 commit comments

Comments
 (0)