Skip to content

Commit f6b16e4

Browse files
committed
app+docker: don't compile protos when building or installing
Because we now have the compiled protos in the git repository, we don't need to compile them with each installation or build.
1 parent 47a4359 commit f6b16e4

File tree

3 files changed

+0
-12
lines changed

3 files changed

+0
-12
lines changed

Dockerfile

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,6 @@ ENV GO111MODULE on
1414

1515
ENV NODE_VERSION=v12.17.0
1616

17-
# We need some additional proto files with google annotations, the version
18-
# should match what's in lnd's scripts/install_travis_proto.sh
19-
ENV PROTOC_VERSION=3.4.0
20-
ENV PROTOC_URL="https://github.com/protocolbuffers/protobuf/releases/download/v${PROTOC_VERSION}/protoc-${PROTOC_VERSION}-linux-x86_64.zip"
21-
2217
# Install dependencies and install/build lightning-terminal.
2318
RUN apk add --no-cache --update alpine-sdk \
2419
git \
@@ -27,11 +22,6 @@ RUN apk add --no-cache --update alpine-sdk \
2722
bash \
2823
binutils \
2924
tar \
30-
protobuf-dev \
31-
zip \
32-
&& curl -sfSLO ${PROTOC_URL} \
33-
&& unzip protoc-${PROTOC_VERSION}-linux-x86_64.zip -d /usr/local \
34-
&& rm /usr/local/bin/protoc /usr/local/readme.txt \
3525
&& touch ~/.bashrc \
3626
&& curl -sfSLO https://unofficial-builds.nodejs.org/download/release/${NODE_VERSION}/node-${NODE_VERSION}-linux-x64-musl.tar.xz \
3727
&& tar -xf node-${NODE_VERSION}-linux-x64-musl.tar.xz -C /usr --strip 1 \

app/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
"eject": "react-scripts eject",
1313
"lint": "eslint --ext .ts,.tsx --ignore-path .eslintignore .",
1414
"tsc": "tsc --noEmit",
15-
"postinstall": "yarn protos",
1615
"protos": "node ./scripts/build-protos.js",
1716
"storybook": "start-storybook -p 9009 -s public",
1817
"build-storybook": "build-storybook -s public"

dev.Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ RUN apk add --no-cache --update alpine-sdk \
2020
bash \
2121
binutils \
2222
tar \
23-
protobuf-dev \
2423
&& touch ~/.bashrc \
2524
&& curl -sfSLO https://unofficial-builds.nodejs.org/download/release/${NODE_VERSION}/node-${NODE_VERSION}-linux-x64-musl.tar.xz \
2625
&& tar -xf node-${NODE_VERSION}-linux-x64-musl.tar.xz -C /usr --strip 1 \

0 commit comments

Comments
 (0)