itest: add itests for the Taproot Assets new subserver

Author: positiveblue

itest/litd_mode_integrated_test.go

@@ -30,6 +30,7 @@ import (
 	pool "github.com/lightninglabs/pool/perms"
 	"github.com/lightninglabs/pool/poolrpc"
 	tap "github.com/lightninglabs/taproot-assets/perms"
+	"github.com/lightninglabs/taproot-assets/taprpc"
 	"github.com/lightningnetwork/lnd/keychain"
 	"github.com/lightningnetwork/lnd/lnrpc"
 	"github.com/lightningnetwork/lnd/lnrpc/routerrpc"
@@ -146,6 +147,15 @@ var (
 	poolMacaroonFn = func(cfg *LitNodeConfig) string {
 		return cfg.PoolMacPath
 	}
+	tapRequestFn = func(ctx context.Context,
+		c grpc.ClientConnInterface) (proto.Message, error) {
+
+		tapConn := taprpc.NewTaprootAssetsClient(c)
+		return tapConn.ListAssets(ctx, &taprpc.ListAssetRequest{})
+	}
+	tapMacaroonFn = func(cfg *LitNodeConfig) string {
+		return cfg.TapMacPath
+	}
 	litSessionRequestFn = func(ctx context.Context,
 		c grpc.ClientConnInterface) (proto.Message, error) {
 
@@ -234,6 +244,14 @@ var (
 		allowedThroughLNC: true,
 		grpcWebURI:        "/poolrpc.Trader/GetInfo",
 		restWebURI:        "/v1/pool/info",
+	}, {
+		name:              "taprpc",
+		macaroonFn:        tapMacaroonFn,
+		requestFn:         tapRequestFn,
+		successPattern:    "\"assets\":[]",
+		allowedThroughLNC: true,
+		grpcWebURI:        "/taprpc.TaprootAssets/ListAssets",
+		restWebURI:        "/v1/taproot-assets/assets",
 	}, {
 		name:       "litrpc-sessions",
 		macaroonFn: litMacaroonFn,
@@ -644,7 +662,13 @@ func runGRPCAuthTest(t *testing.T, hostPort, tlsCertPath, macPath string,
 	ctxm = macaroonContext(ctxt, dummyMacBytes)
 	_, err = makeRequest(ctxm, rawConn)
 	require.Error(t, err)
-	require.Contains(t, err.Error(), "cannot get macaroon: root key with")
+
+	errStr := err.Error()
+	err1 := strings.Contains(errStr, "cannot get macaroon: root")
+	err2 := strings.Contains(errStr, "cannot get macaroon: sql: no")
+	require.Truef(
+		t, err1 || err2, "no macaroon, got unexpected error: %v", err,
+	)
 
 	// Then finally we try with the correct macaroon which should now
 	// succeed.
@@ -692,7 +716,9 @@ func runUIPasswordCheck(t *testing.T, hostPort, tlsCertPath, uiPassword string,
 	errStr := err.Error()
 	err1 := strings.Contains(errStr, "invalid auth: invalid basic auth")
 	err2 := strings.Contains(errStr, "cannot get macaroon: root key with")
-	require.True(t, err1 || err2, "wrong UI password and dummy mac")
+	err3 := strings.Contains(errStr, "cannot get macaroon: sql: no rows")
+	require.Truef(t, err1 || err2 || err3, "wrong UI password and dummy "+
+		"mac, got unexpected error: %v", err)
 
 	// Using the correct UI password should work for all requests.
 	ctxm = uiPasswordContext(ctxt, uiPassword, false)
@@ -712,9 +738,11 @@ func runUIPasswordCheck(t *testing.T, hostPort, tlsCertPath, uiPassword string,
 		_, err = makeRequest(ctxm, rawConn)
 
 		require.Error(t, err)
-		require.Contains(
-			t, err.Error(), "cannot get macaroon: root",
-		)
+		errStr := err.Error()
+		err1 := strings.Contains(errStr, "cannot get macaroon: root")
+		err2 := strings.Contains(errStr, "cannot get macaroon: sql: no")
+		require.Truef(t, err1 || err2, "no macaroon, got unexpected "+
+			"error: %v", err)
 		return
 	}
 
@@ -1097,6 +1125,7 @@ func bakeSuperMacaroon(cfg *LitNodeConfig, readOnly bool) (string, error) {
 
 	permsMgr.RegisterSubServer(subservers.LOOP, loop.RequiredPermissions)
 	permsMgr.RegisterSubServer(subservers.POOL, pool.RequiredPermissions)
+	permsMgr.RegisterSubServer(subservers.TAP, tap.RequiredPermissions)
 	permsMgr.RegisterSubServer(
 		subservers.FARADAY, faraday.RequiredPermissions,
 	)

itest/litd_node.go

@@ -27,6 +27,7 @@ import (
 	"github.com/lightninglabs/lightning-terminal/litrpc"
 	"github.com/lightninglabs/loop/looprpc"
 	"github.com/lightninglabs/pool/poolrpc"
+	"github.com/lightninglabs/taproot-assets/taprpc"
 	"github.com/lightningnetwork/lnd/lnrpc"
 	"github.com/lightningnetwork/lnd/lnrpc/invoicesrpc"
 	"github.com/lightningnetwork/lnd/lnrpc/routerrpc"
@@ -71,6 +72,7 @@ type LitNodeConfig struct {
 	FaradayMacPath string
 	LoopMacPath    string
 	PoolMacPath    string
+	TapMacPath     string
 	LitTLSCertPath string
 	LitMacPath     string
 
@@ -79,6 +81,7 @@ type LitNodeConfig struct {
 	FaradayDir string
 	LoopDir    string
 	PoolDir    string
+	TapdDir    string
 
 	LitPort     int
 	LitRESTPort int
@@ -182,15 +185,16 @@ func (cfg *LitNodeConfig) GenArgs(opts ...LitArgOption) []string {
 func (cfg *LitNodeConfig) defaultLitdArgs() *litArgs {
 	var (
 		args = map[string]string{
-			"httpslisten":         cfg.LitAddr(),
-			"insecure-httplisten": cfg.LitRESTAddr(),
-			"lit-dir":             cfg.LitDir,
-			"faraday.faradaydir":  cfg.FaradayDir,
-			"loop.loopdir":        cfg.LoopDir,
-			"pool.basedir":        cfg.PoolDir,
-			"uipassword":          cfg.UIPassword,
-			"enablerest":          "",
-			"restcors":            "*",
+			"httpslisten":            cfg.LitAddr(),
+			"insecure-httplisten":    cfg.LitRESTAddr(),
+			"lit-dir":                cfg.LitDir,
+			"faraday.faradaydir":     cfg.FaradayDir,
+			"loop.loopdir":           cfg.LoopDir,
+			"pool.basedir":           cfg.PoolDir,
+			"taproot-assets.tapddir": cfg.TapdDir,
+			"uipassword":             cfg.UIPassword,
+			"enablerest":             "",
+			"restcors":               "*",
 		}
 	)
 	for _, arg := range cfg.LitArgs {
@@ -356,6 +360,7 @@ func NewNode(t *testing.T, cfg *LitNodeConfig,
 	cfg.FaradayDir = filepath.Join(cfg.LitDir, "faraday")
 	cfg.LoopDir = filepath.Join(cfg.LitDir, "loop")
 	cfg.PoolDir = filepath.Join(cfg.LitDir, "pool")
+	cfg.TapdDir = filepath.Join(cfg.LitDir, "tapd")
 	cfg.TLSCertPath = filepath.Join(cfg.BaseDir, "tls.cert")
 	cfg.TLSKeyPath = filepath.Join(cfg.BaseDir, "tls.key")
 
@@ -374,6 +379,9 @@ func NewNode(t *testing.T, cfg *LitNodeConfig,
 	cfg.PoolMacPath = filepath.Join(
 		cfg.PoolDir, cfg.NetParams.Name, "pool.macaroon",
 	)
+	cfg.TapMacPath = filepath.Join(
+		cfg.TapdDir, "data", cfg.NetParams.Name, "admin.macaroon",
+	)
 	cfg.LitMacPath = filepath.Join(
 		cfg.LitDir, cfg.NetParams.Name, "lit.macaroon",
 	)
@@ -730,6 +738,18 @@ func (hn *HarnessNode) WaitUntilStarted(conn grpc.ClientConnInterface,
 			return err
 		}
 
+		tapClient, err := hn.tapClient()
+		if err != nil {
+			return err
+		}
+
+		_, err = tapClient.ListAssets(
+			ctxt, &taprpc.ListAssetRequest{},
+		)
+		if err != nil {
+			return err
+		}
+
 		return nil
 	}, timeout)
 }
@@ -778,6 +798,20 @@ func (hn *HarnessNode) poolClient() (poolrpc.TraderClient, error) {
 	return poolrpc.NewTraderClient(conn), nil
 }
 
+func (hn *HarnessNode) tapClient() (taprpc.TaprootAssetsClient, error) {
+	mac, err := hn.ReadMacaroon(hn.Cfg.TapMacPath, lntest.DefaultTimeout)
+	if err != nil {
+		return nil, err
+	}
+
+	conn, err := hn.ConnectRPCWithMacaroon(mac)
+	if err != nil {
+		return nil, err
+	}
+
+	return taprpc.NewTaprootAssetsClient(conn), nil
+}
+
 // waitForState waits until the current node state fulfills the given
 // predicate.
 func (hn *HarnessNode) waitForState(conn grpc.ClientConnInterface,