Skip to content

Commit 8f5f35b

Browse files
committed
session: do full session assertion during tests
Make sure to compare the full expected and actual Session struct during tests.
1 parent c0e85e0 commit 8f5f35b

File tree

1 file changed

+31
-2
lines changed

1 file changed

+31
-2
lines changed

session/store_test.go

Lines changed: 31 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,11 @@ func TestBasicSessionStore(t *testing.T) {
5151
for _, s := range []*Session{s1, s2, s3} {
5252
session, err := db.GetSession(s.LocalPublicKey)
5353
require.NoError(t, err)
54-
require.Equal(t, s.Label, session.Label)
54+
assertEqualSessions(t, s, session)
5555

5656
session, err = db.GetSessionByID(s.ID)
5757
require.NoError(t, err)
58-
require.Equal(t, s.Label, session.Label)
58+
assertEqualSessions(t, s, session)
5959
}
6060

6161
// Fetch session 1 and assert that it currently has no remote pub key.
@@ -295,3 +295,32 @@ func newSession(t *testing.T, db Store, label string,
295295

296296
return session
297297
}
298+
299+
func assertEqualSessions(t *testing.T, expected, actual *Session) {
300+
expectedExpiry := expected.Expiry
301+
actualExpiry := actual.Expiry
302+
expectedRevoked := expected.RevokedAt
303+
actualRevoked := actual.RevokedAt
304+
expectedCreated := expected.CreatedAt
305+
actualCreated := actual.CreatedAt
306+
307+
expected.Expiry = time.Time{}
308+
expected.RevokedAt = time.Time{}
309+
expected.CreatedAt = time.Time{}
310+
actual.Expiry = time.Time{}
311+
actual.RevokedAt = time.Time{}
312+
actual.CreatedAt = time.Time{}
313+
314+
require.Equal(t, expected, actual)
315+
require.Equal(t, expectedExpiry.Unix(), actualExpiry.Unix())
316+
require.Equal(t, expectedRevoked.Unix(), actualRevoked.Unix())
317+
require.Equal(t, expectedCreated.Unix(), actualCreated.Unix())
318+
319+
// Restore the old values to not influence the tests.
320+
expected.Expiry = expectedExpiry
321+
expected.RevokedAt = expectedRevoked
322+
expected.CreatedAt = expectedCreated
323+
actual.Expiry = actualExpiry
324+
actual.RevokedAt = actualRevoked
325+
actual.CreatedAt = actualCreated
326+
}

0 commit comments

Comments
 (0)