firewalldb: update NewTestDB funcs to return FirewallDBs

In the upcoming migration of the firewall database to SQL, the helper
functions that creates the test databases of different types, need to
return a unified interface in order to not have to control the
migration tests file by build tags. Therefore, we update the
`NewTestDB` functions to return the `FirewallDBs` interface instead of
the specific store implementation type.

Author: ViktorTigerstrom

firewalldb/test_kvdb.go

@@ -6,42 +6,46 @@ import (
 	"testing"
 
 	"github.com/lightninglabs/lightning-terminal/accounts"
+	"github.com/lightninglabs/lightning-terminal/session"
 	"github.com/lightningnetwork/lnd/clock"
 	"github.com/lightningnetwork/lnd/fn"
 	"github.com/stretchr/testify/require"
 )
 
 // NewTestDB is a helper function that creates an BBolt database for testing.
-func NewTestDB(t *testing.T, clock clock.Clock) *BoltDB {
+func NewTestDB(t *testing.T, clock clock.Clock) FirewallDBs {
 	return NewTestDBFromPath(t, t.TempDir(), clock)
 }
 
 // NewTestDBFromPath is a helper function that creates a new BoltStore with a
 // connection to an existing BBolt database for testing.
-func NewTestDBFromPath(t *testing.T, dbPath string, clock clock.Clock) *BoltDB {
+func NewTestDBFromPath(t *testing.T, dbPath string,
+	clock clock.Clock) FirewallDBs {
+
 	return newDBFromPathWithSessions(t, dbPath, nil, nil, clock)
 }
 
 // NewTestDBWithSessions creates a new test BoltDB Store with access to an
 // existing sessions DB.
-func NewTestDBWithSessions(t *testing.T, sessStore SessionDB,
-	clock clock.Clock) *BoltDB {
+func NewTestDBWithSessions(t *testing.T, sessStore session.Store,
+	clock clock.Clock) FirewallDBs {
 
 	return newDBFromPathWithSessions(t, t.TempDir(), sessStore, nil, clock)
 }
 
 // NewTestDBWithSessionsAndAccounts creates a new test BoltDB Store with access
 // to an existing sessions DB and accounts DB.
-func NewTestDBWithSessionsAndAccounts(t *testing.T, sessStore SessionDB,
-	acctStore AccountsDB, clock clock.Clock) *BoltDB {
+func NewTestDBWithSessionsAndAccounts(t *testing.T, sessStore session.Store,
+	acctStore AccountsDB, clock clock.Clock) FirewallDBs {
 
 	return newDBFromPathWithSessions(
 		t, t.TempDir(), sessStore, acctStore, clock,
 	)
 }
 
 func newDBFromPathWithSessions(t *testing.T, dbPath string,
-	sessStore SessionDB, acctStore AccountsDB, clock clock.Clock) *BoltDB {
+	sessStore session.Store, acctStore AccountsDB,
+	clock clock.Clock) FirewallDBs {
 
 	store, err := NewBoltDB(dbPath, DBFilename, sessStore, acctStore, clock)
 	require.NoError(t, err)

firewalldb/test_postgres.go

@@ -10,12 +10,12 @@ import (
 )
 
 // NewTestDB is a helper function that creates an BBolt database for testing.
-func NewTestDB(t *testing.T, clock clock.Clock) *SQLDB {
+func NewTestDB(t *testing.T, clock clock.Clock) FirewallDBs {
 	return createStore(t, db.NewTestPostgresDB(t).BaseDB, clock)
 }
 
 // NewTestDBFromPath is a helper function that creates a new BoltStore with a
 // connection to an existing BBolt database for testing.
-func NewTestDBFromPath(t *testing.T, _ string, clock clock.Clock) *SQLDB {
+func NewTestDBFromPath(t *testing.T, _ string, clock clock.Clock) FirewallDBs {
 	return createStore(t, db.NewTestPostgresDB(t).BaseDB, clock)
 }

firewalldb/test_sql.go

@@ -16,8 +16,7 @@ import (
 // NewTestDBWithSessions creates a new test SQLDB Store with access to an
 // existing sessions DB.
 func NewTestDBWithSessions(t *testing.T, sessionStore session.Store,
-	clock clock.Clock) *SQLDB {
-
+	clock clock.Clock) FirewallDBs {
 	sessions, ok := sessionStore.(*session.SQLStore)
 	require.True(t, ok)
 
@@ -27,7 +26,7 @@ func NewTestDBWithSessions(t *testing.T, sessionStore session.Store,
 // NewTestDBWithSessionsAndAccounts creates a new test SQLDB Store with access
 // to an existing sessions DB and accounts DB.
 func NewTestDBWithSessionsAndAccounts(t *testing.T, sessionStore SessionDB,
-	acctStore AccountsDB, clock clock.Clock) *SQLDB {
+	acctStore AccountsDB, clock clock.Clock) FirewallDBs {
 
 	sessions, ok := sessionStore.(*session.SQLStore)
 	require.True(t, ok)

firewalldb/test_sqlite.go

@@ -10,13 +10,13 @@ import (
 )
 
 // NewTestDB is a helper function that creates an BBolt database for testing.
-func NewTestDB(t *testing.T, clock clock.Clock) *SQLDB {
+func NewTestDB(t *testing.T, clock clock.Clock) FirewallDBs {
 	return createStore(t, db.NewTestSqliteDB(t).BaseDB, clock)
 }
 
 // NewTestDBFromPath is a helper function that creates a new BoltStore with a
 // connection to an existing BBolt database for testing.
-func NewTestDBFromPath(t *testing.T, dbPath string, clock clock.Clock) *SQLDB {
+func NewTestDBFromPath(t *testing.T, dbPath string, clock clock.Clock) FirewallDBs {
 	return createStore(
 		t, db.NewTestSqliteDbHandleFromPath(t, dbPath).BaseDB, clock,
 	)