Skip to content

Commit 3ee5ec2

Browse files
committed
mod+accounts: bump lndclient dep, split mocks
Because each lndclient service mock now needs to implement the RawClientWithMacAuth method but with a different type, we can't implement two lndclient service mocks within a single struct, as that would require us to have two methods with the same name but different types. So we split the lnd and rounter mocks into two separate structs.
1 parent 3280923 commit 3ee5ec2

File tree

4 files changed

+155
-91
lines changed

4 files changed

+155
-91
lines changed

accounts/checkers_test.go

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -513,13 +513,14 @@ func testSendPayment(t *testing.T, uri string) {
513513
}
514514

515515
lndMock := newMockLnd()
516+
routerMock := newMockRouter()
516517
errFunc := func(err error) {
517518
lndMock.mainErrChan <- err
518519
}
519520
service, err := NewService(t.TempDir(), errFunc)
520521
require.NoError(t, err)
521522

522-
err = service.Start(lndMock, lndMock, chainParams)
523+
err = service.Start(lndMock, routerMock, chainParams)
523524
require.NoError(t, err)
524525

525526
assertBalance := func(id AccountID, expectedBalance int64) {
@@ -615,7 +616,7 @@ func testSendPayment(t *testing.T, uri string) {
615616
require.NoError(t, err)
616617
assertBalance(acct.ID, 4000)
617618

618-
lndMock.assertPaymentRequests(t, map[lntypes.Hash]struct{}{
619+
routerMock.assertPaymentRequests(t, map[lntypes.Hash]struct{}{
619620
testHash: {},
620621
})
621622

@@ -646,7 +647,7 @@ func testSendPayment(t *testing.T, uri string) {
646647
// was initiated.
647648
assertBalance(acct.ID, 4000)
648649

649-
lndMock.assertNoPaymentRequest(t)
650+
routerMock.assertNoPaymentRequest(t)
650651

651652
// The final test we will do is to have two send requests initiated
652653
// before the response for the first one has been received.
@@ -708,13 +709,14 @@ func TestSendPaymentV2(t *testing.T) {
708709
}
709710

710711
lndMock := newMockLnd()
712+
routerMock := newMockRouter()
711713
errFunc := func(err error) {
712714
lndMock.mainErrChan <- err
713715
}
714716
service, err := NewService(t.TempDir(), errFunc)
715717
require.NoError(t, err)
716718

717-
err = service.Start(lndMock, lndMock, chainParams)
719+
err = service.Start(lndMock, routerMock, chainParams)
718720
require.NoError(t, err)
719721

720722
assertBalance := func(id AccountID, expectedBalance int64) {
@@ -808,7 +810,7 @@ func TestSendPaymentV2(t *testing.T) {
808810
require.NoError(t, err)
809811
assertBalance(acct.ID, 4000)
810812

811-
lndMock.assertPaymentRequests(t, map[lntypes.Hash]struct{}{
813+
routerMock.assertPaymentRequests(t, map[lntypes.Hash]struct{}{
812814
testHash: {},
813815
})
814816

@@ -836,7 +838,7 @@ func TestSendPaymentV2(t *testing.T) {
836838
// was initiated.
837839
assertBalance(acct.ID, 4000)
838840

839-
lndMock.assertNoPaymentRequest(t)
841+
routerMock.assertNoPaymentRequest(t)
840842

841843
// The final test we will do is to have two send requests initiated
842844
// before the response for the first one has been received.
@@ -894,13 +896,14 @@ func TestSendToRouteV2(t *testing.T) {
894896
}
895897

896898
lndMock := newMockLnd()
899+
routerMock := newMockRouter()
897900
errFunc := func(err error) {
898901
lndMock.mainErrChan <- err
899902
}
900903
service, err := NewService(t.TempDir(), errFunc)
901904
require.NoError(t, err)
902905

903-
err = service.Start(lndMock, lndMock, chainParams)
906+
err = service.Start(lndMock, routerMock, chainParams)
904907
require.NoError(t, err)
905908

906909
assertBalance := func(id AccountID, expectedBalance int64) {
@@ -998,7 +1001,7 @@ func TestSendToRouteV2(t *testing.T) {
9981001
require.NoError(t, err)
9991002
assertBalance(acct.ID, 4000)
10001003

1001-
lndMock.assertPaymentRequests(t, map[lntypes.Hash]struct{}{
1004+
routerMock.assertPaymentRequests(t, map[lntypes.Hash]struct{}{
10021005
testHash: {},
10031006
})
10041007

@@ -1028,7 +1031,7 @@ func TestSendToRouteV2(t *testing.T) {
10281031
// was initiated.
10291032
assertBalance(acct.ID, 4000)
10301033

1031-
lndMock.assertNoPaymentRequest(t)
1034+
routerMock.assertNoPaymentRequest(t)
10321035

10331036
// The final test we will do is to have two send requests initiated
10341037
// before the response for the first one has been received.

0 commit comments

Comments
 (0)