Skip to content

Commit 2150446

Browse files
authored
Merge pull request #896 from lightninglabs/grpc-log-off
config: disable internal GRPC logger by default
2 parents cb6977f + 95e289c commit 2150446

File tree

2 files changed

+53
-7
lines changed

2 files changed

+53
-7
lines changed

config.go

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -386,15 +386,19 @@ func loadAndValidateConfig(interceptor signal.Interceptor) (*Config, error) {
386386
// the debug log level(s). In remote lnd mode we have a global log level
387387
// that overwrites all others. In integrated mode we use the lnd log
388388
// level as the master level.
389+
debuglevel := cfg.Lnd.DebugLevel
389390
if cfg.lndRemote {
390-
err = build.ParseAndSetDebugLevels(
391-
cfg.Remote.LitDebugLevel, cfg.Lnd.LogWriter,
392-
)
393-
} else {
394-
err = build.ParseAndSetDebugLevels(
395-
cfg.Lnd.DebugLevel, cfg.Lnd.LogWriter,
396-
)
391+
debuglevel = cfg.Remote.LitDebugLevel
397392
}
393+
394+
// By default, we don't want the GRPC connection-level logger to be
395+
// turned on. So if it isn't specifically mentioned in the debug level
396+
// string, we'll disable it.
397+
if !strings.Contains(debuglevel, GrpcLogSubsystem) {
398+
debuglevel += fmt.Sprintf(",%s=off", GrpcLogSubsystem)
399+
}
400+
401+
err = build.ParseAndSetDebugLevels(debuglevel, cfg.Lnd.LogWriter)
398402
if err != nil {
399403
return nil, err
400404
}
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
# Release Notes
2+
3+
- [Lightning Terminal](#lightning-terminal)
4+
- [Bug Fixes](#bug-fixes)
5+
- [Functional Changes/Additions](#functional-changesadditions)
6+
- [Technical and Architectural Updates](#technical-and-architectural-updates)
7+
- [Integrated Binary Updates](#integrated-binary-updates)
8+
- [LND](#lnd)
9+
- [Loop](#loop)
10+
- [Pool](#pool)
11+
- [Faraday](#faraday)
12+
- [Taproot Assets](#taproot-assets)
13+
- [Contributors](#contributors-alphabetical-order)
14+
15+
## Lightning Terminal
16+
17+
### Bug Fixes
18+
19+
* [Disable the `GRPC` internal low-level connection logger by
20+
default](https://github.com/lightninglabs/lightning-terminal/pull/896).
21+
It can still be enabled by adding `,GRPC=info` at the end of the
22+
`lnd.debuglevel` or `remote.lit-debuglevel` configuration options.
23+
24+
### Functional Changes/Additions
25+
26+
### Technical and Architectural Updates
27+
28+
## Integrated Binary Updates
29+
30+
### LND
31+
32+
### Loop
33+
34+
### Pool
35+
36+
### Faraday
37+
38+
### Taproot Assets
39+
40+
# Contributors (Alphabetical Order)
41+
42+
- Oliver Gugger

0 commit comments

Comments
 (0)