-
Notifications
You must be signed in to change notification settings - Fork 418
Closed
Labels
Take a Friday Leave a FridayStomp the Bugs, Without Much CommitmentStomp the Bugs, Without Much Commitment
Description
1. When sending a payment via the async BOLT12 flow introduced in #3078, we would log-and-swallow any path finding errors and silently abandon the payment:
rust-lightning/lightning/src/ln/outbound_payment.rs
Lines 1019 to 1021 in 669a459
log_error!(logger, "Failed to find a route on retry, abandoning payment {}: {:#?}", &payment_id, e); | |
self.abandon_payment(payment_id, PaymentFailureReason::RouteNotFound, pending_events); | |
return |
In order to tell the user what went wrong, it would be great to bubble up the Err
from find_route_and_send_payment
rather than continuing and returning Ok(())
.
~~2. We should also early-abort sending in the regular pay_for_offer
flow if we're certain we don't have sufficient liquidity (i.e. the offer amount surpasses the sum of our available next_outbound_htlc_limit_msat
s) ~~
Metadata
Metadata
Assignees
Labels
Take a Friday Leave a FridayStomp the Bugs, Without Much CommitmentStomp the Bugs, Without Much Commitment