Skip to content

Commit 894caef

Browse files
committed
f remove TODOs sighash_all checks
1 parent 32e93ac commit 894caef

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

lightning/src/ln/channel.rs

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7592,20 +7592,12 @@ where
75927592
}
75937593
}
75947594

7595-
fn verify_interactive_tx_signatures(&mut self, _witnesses: &Vec<Witness>) {
7596-
if let Some(ref mut _signing_session) = self.interactive_tx_signing_session {
7597-
// Check that sighash_all was used:
7598-
// TODO(dual_funding): Check sig for sighash
7599-
}
7600-
}
7601-
76027595
pub fn funding_transaction_signed<L: Deref>(
76037596
&mut self, witnesses: Vec<Witness>, logger: &L,
76047597
) -> Result<Option<msgs::TxSignatures>, APIError>
76057598
where
76067599
L::Target: Logger,
76077600
{
7608-
self.verify_interactive_tx_signatures(&witnesses);
76097601
if let Some(ref mut signing_session) = self.interactive_tx_signing_session {
76107602
let logger = WithChannelContext::from(logger, &self.context, None);
76117603
if let Some(holder_tx_signatures) = signing_session
@@ -7675,11 +7667,6 @@ where
76757667
ClosureReason::HolderForceClosed { broadcasted_latest_txn: Some(false) },
76767668
)));
76777669
}
7678-
7679-
// TODO(dual_funding): Check all sigs are SIGHASH_ALL.
7680-
7681-
// TODO(dual_funding): I don't see how we're going to be able to ensure witness-standardness
7682-
// for spending. Doesn't seem to be anything in rust-bitcoin.
76837670
}
76847671

76857672
let (holder_tx_signatures_opt, funding_tx_opt) = signing_session.received_tx_signatures(msg.clone())

0 commit comments

Comments
 (0)