Move PendingSpliceInfoPre to Channel (from ChannelContext)

Author: optout21

lightning/src/ln/channel.rs

@@ -1485,10 +1485,6 @@ pub(super) struct ChannelContext<SP: Deref> where SP::Target: SignerProvider {
 	secp_ctx: Secp256k1<secp256k1::All>,
 	channel_value_satoshis: u64,
 
-	/// Info about an in-progress, pending splice (if any), on the pre-splice channel
-	#[cfg(splicing)]
-	pending_splice_pre: Option<PendingSpliceInfoPre>,
-	
 	latest_monitor_update_id: u64,
 
 	holder_signer: ChannelSignerType<SP>,
@@ -2543,9 +2539,6 @@ impl<SP: Deref> ChannelContext<SP> where SP::Target: SignerProvider {
 			is_manual_broadcast: false,
 
 			next_funding_txid: None,
-
-			#[cfg(splicing)]
-			pending_splice_pre: None,
 		};
 
 		Ok(channel_context)
@@ -2776,9 +2769,6 @@ impl<SP: Deref> ChannelContext<SP> where SP::Target: SignerProvider {
 			local_initiated_shutdown: None,
 			is_manual_broadcast: false,
 			next_funding_txid: None,
-
-			#[cfg(splicing)]
-			pending_splice_pre: None,
 		})
 	}
 
@@ -4610,6 +4600,9 @@ pub(super) struct FundedChannel<SP: Deref> where SP::Target: SignerProvider {
 	pub context: ChannelContext<SP>,
 	pub interactive_tx_signing_session: Option<InteractiveTxSigningSession>,
 	holder_commitment_point: HolderCommitmentPoint,
+	/// Info about an in-progress, pending splice (if any), on the pre-splice channel
+	#[cfg(splicing)]
+	pending_splice_pre: Option<PendingSpliceInfoPre>,
 }
 
 #[cfg(any(test, fuzzing))]
@@ -8231,7 +8224,7 @@ impl<SP: Deref> FundedChannel<SP> where
 	) -> Result<msgs::SpliceInit, ChannelError> {
 		// Check if a splice has been initiated already.
 		// Note: this could be handled more nicely, and support multiple outstanding splice's, the incoming splice_ack matters anyways.
-		if let Some(splice_info) = &self.context.pending_splice_pre {
+		if let Some(splice_info) = &self.pending_splice_pre {
 			return Err(ChannelError::Warn(format!(
 				"Channel has already a splice pending, contribution {}", splice_info.our_funding_contribution
 			)));
@@ -8260,7 +8253,7 @@ impl<SP: Deref> FundedChannel<SP> where
 		// Note: post-splice channel value is not yet known at this point, counterpary contribution is not known
 		// (Cannot test for miminum required post-splice channel value)
 
-		self.context.pending_splice_pre = Some(PendingSpliceInfoPre {
+		self.pending_splice_pre = Some(PendingSpliceInfoPre {
 			our_funding_contribution: our_funding_contribution_satoshis,
 		});
 
@@ -8277,7 +8270,7 @@ impl<SP: Deref> FundedChannel<SP> where
 
 		// Check if a splice has been initiated already.
 		// Note: this could be handled more nicely, and support multiple outstanding splice's, the incoming splice_ack matters anyways.
-		if let Some(splice_info) = &self.context.pending_splice_pre {
+		if let Some(splice_info) = &self.pending_splice_pre {
 			return Err(ChannelError::Warn(format!(
 				"Channel has already a splice pending, contribution {}", splice_info.our_funding_contribution,
 			)));
@@ -8326,7 +8319,7 @@ impl<SP: Deref> FundedChannel<SP> where
 		let their_funding_contribution_satoshis = msg.funding_contribution_satoshis;
 
 		// check if splice is pending
-		let pending_splice = if let Some(pending_splice) = &self.context.pending_splice_pre {
+		let pending_splice = if let Some(pending_splice) = &self.pending_splice_pre {
 			pending_splice
 		} else {
 			return Err(ChannelError::Warn(format!("Channel is not in pending splice")));
@@ -9036,6 +9029,8 @@ impl<SP: Deref> OutboundV1Channel<SP> where SP::Target: SignerProvider {
 			context: self.context,
 			interactive_tx_signing_session: None,
 			holder_commitment_point,
+			#[cfg(splicing)]
+			pending_splice_pre: None,
 		};
 
 		let need_channel_ready = channel.check_get_channel_ready(0, logger).is_some()
@@ -9301,6 +9296,8 @@ impl<SP: Deref> InboundV1Channel<SP> where SP::Target: SignerProvider {
 			context: self.context,
 			interactive_tx_signing_session: None,
 			holder_commitment_point,
+			#[cfg(splicing)]
+			pending_splice_pre: None,
 		};
 		let need_channel_ready = channel.check_get_channel_ready(0, logger).is_some()
 			|| channel.context.signer_pending_channel_ready;
@@ -9664,6 +9661,8 @@ impl<SP: Deref> PendingV2Channel<SP> where SP::Target: SignerProvider {
 			context: self.context,
 			interactive_tx_signing_session: Some(signing_session),
 			holder_commitment_point,
+			#[cfg(splicing)]
+			pending_splice_pre: None,
 		};
 
 		Ok(channel)
@@ -10741,12 +10740,11 @@ impl<'a, 'b, 'c, ES: Deref, SP: Deref> ReadableArgs<(&'a ES, &'b SP, u32, &'c Ch
 				// during a signing session, but have not received `tx_signatures` we MUST set `next_funding_txid`
 				// to the txid of that interactive transaction, else we MUST NOT set it.
 				next_funding_txid: None,
-
-				#[cfg(splicing)]
-				pending_splice_pre: None,
 			},
 			interactive_tx_signing_session: None,
 			holder_commitment_point,
+			#[cfg(splicing)]
+			pending_splice_pre: None,
 		})
 	}
 }

lightning/src/ln/channelmanager.rs

@@ -4226,7 +4226,7 @@ where
 		// Look for the channel
 		match peer_state.channel_by_id.entry(*channel_id) {
 			hash_map::Entry::Occupied(mut chan_phase_entry) => {
-				if let ChannelPhase::Funded(chan) = chan_phase_entry.get_mut() {
+				if let Some(chan) = chan_phase_entry.get_mut().as_funded_mut() {
 					let msg = match chan.splice_channel(our_funding_contribution_satoshis, funding_feerate_perkw, locktime) {
 						Ok(msg) => msg,
 						Err(err) => return Err(APIError::APIMisuseError {
@@ -9380,7 +9380,7 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
 					counterparty_node_id, msg.channel_id,
 				), msg.channel_id)),
 			hash_map::Entry::Occupied(mut chan_entry) => {
-				if let ChannelPhase::Funded(chan) = chan_entry.get_mut() {
+				if let Some(chan) = chan_entry.get_mut().as_funded_mut() {
 					match chan.splice_init(msg) {
 						Ok(splice_ack_msg) => {
 							peer_state.pending_msg_events.push(events::MessageSendEvent::SendSpliceAck {
@@ -9425,7 +9425,7 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
 					counterparty_node_id
 				), msg.channel_id)),
 			hash_map::Entry::Occupied(mut chan) => {
-				if let ChannelPhase::Funded(chan) = chan.get_mut() {
+				if let Some(chan) = chan.get_mut().as_funded_mut() {
 					match chan.splice_ack(msg) {
 						Ok(_) => {}
 						Err(err) => {