Skip to content

Commit 222edc2

Browse files
committed
Clean up unreadable assertions in expect_payment_forwarded
In some cases `rustfmt` makes long boolean expressions fairly difficult to parse. Here we clean up a specific case in `functional_test_utils.rs` which was recently exposed.
1 parent 6bafb2a commit 222edc2

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

lightning/src/ln/functional_test_utils.rs

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3056,12 +3056,14 @@ pub fn expect_payment_forwarded<CM: AChannelManager, H: NodeHolder<CM = CM>>(
30563056
// overpaid amount.
30573057
assert!(skimmed_fee_msat == expected_extra_fees_msat);
30583058
if !upstream_force_closed {
3059+
assert_eq!(prev_node.node().get_our_node_id(), prev_node_id.unwrap());
30593060
// Is the event prev_channel_id in one of the channels between the two nodes?
3060-
assert!(node.node().list_channels().iter().any(|x| x.counterparty.node_id
3061-
== prev_node.node().get_our_node_id()
3062-
&& prev_node.node().get_our_node_id() == prev_node_id.unwrap()
3063-
&& x.channel_id == prev_channel_id.unwrap()
3064-
&& x.user_channel_id == prev_user_channel_id.unwrap()));
3061+
let node_chans = node.node().list_channels();
3062+
assert!(node_chans
3063+
.iter()
3064+
.any(|x| x.counterparty.node_id == prev_node_id.unwrap()
3065+
&& x.channel_id == prev_channel_id.unwrap()
3066+
&& x.user_channel_id == prev_user_channel_id.unwrap()));
30653067
}
30663068
// We check for force closures since a force closed channel is removed from the
30673069
// node's channel list
@@ -3070,20 +3072,19 @@ pub fn expect_payment_forwarded<CM: AChannelManager, H: NodeHolder<CM = CM>>(
30703072
// onchain transaction, just as the `total_fee_earned_msat` field. Rather than
30713073
// introducing yet another variable, we use the latter's state as a flag to detect
30723074
// this and only check if it's `Some`.
3075+
assert_eq!(next_node.node().get_our_node_id(), next_node_id.unwrap());
3076+
let node_chans = node.node().list_channels();
30733077
if total_fee_earned_msat.is_none() {
3074-
assert!(node
3075-
.node()
3076-
.list_channels()
3078+
assert!(node_chans
30773079
.iter()
3078-
.any(|x| x.counterparty.node_id == next_node.node().get_our_node_id()
3079-
&& next_node.node().get_our_node_id() == next_node_id.unwrap()
3080+
.any(|x| x.counterparty.node_id == next_node_id.unwrap()
30803081
&& x.channel_id == next_channel_id.unwrap()));
30813082
} else {
3082-
assert!(node.node().list_channels().iter().any(|x| x.counterparty.node_id
3083-
== next_node.node().get_our_node_id()
3084-
&& next_node.node().get_our_node_id() == next_node_id.unwrap()
3085-
&& x.channel_id == next_channel_id.unwrap()
3086-
&& x.user_channel_id == next_user_channel_id.unwrap()));
3083+
assert!(node_chans
3084+
.iter()
3085+
.any(|x| x.counterparty.node_id == next_node_id.unwrap()
3086+
&& x.channel_id == next_channel_id.unwrap()
3087+
&& x.user_channel_id == next_user_channel_id.unwrap()));
30873088
}
30883089
}
30893090
assert_eq!(claim_from_onchain_tx, downstream_force_closed);

0 commit comments

Comments
 (0)