command in CLI to close channel

[elnosh]

add command to the CLI to close a channel. I see close_channel method is already there in the ldk-server-client to be used.

[G8XSU]

Should be doable after #56

[moisesPompilio]

I'd like to support this proposal and suggest the following behavior regarding environment variables:

1. Use environment variables to fully configure a node

It would be very helpful if all the essential configuration needed to start the node could be set via environment variables — without requiring a .toml file. This is especially useful for containerized deployments or dynamic environments (e.g., testing, CI, fuzzing).

2. Environment variables should override values from the .toml file

When both a .toml file and environment variables are provided, the values from the environment variables should take precedence. This allows using a common base .toml file with dynamic overrides, without having to create separate config files per environment.

Suggested environment variables

Here’s a set of variables I think would cover the core configuration needed to bootstrap an LDK node:

--node-network = "regtest"                        # Bitcoin network to use
--node-listening_address = "localhost:3001"       # Lightning node listening address
--node-rest_service_address = "127.0.0.1:3002"    # LDK server REST API address
--bitcoind-rpc_address = "127.0.0.1:18444"        # Bitcoin Core RPC address
--bitcoind-rpc-user = "user"                      # RPC username
--bitcoind-rpc-password = "password"              # RPC password
--storage-dir-path = "/tmp/ldk-server/"           # Path to store LDK/BDK data

[jkczyz]

I'd like to support this proposal and suggest the following behavior regarding environment variables:

1. Use environment variables to fully configure a node

It would be very helpful if all the essential configuration needed to start the node could be set via environment variables — without requiring a .toml file. This is especially useful for containerized deployments or dynamic environments (e.g., testing, CI, fuzzing).

2. Environment variables should override values from the .toml file

When both a .toml file and environment variables are provided, the values from the environment variables should take precedence. This allows using a common base .toml file with dynamic overrides, without having to create separate config files per environment.

Suggested environment variables

Here’s a set of variables I think would cover the core configuration needed to bootstrap an LDK node:

--node-network = "regtest" # Bitcoin network to use
--node-listening_address = "localhost:3001" # Lightning node listening address
--node-rest_service_address = "127.0.0.1:3002" # LDK server REST API address
--bitcoind-rpc_address = "127.0.0.1:18444" # Bitcoin Core RPC address
--bitcoind-rpc-user = "user" # RPC username
--bitcoind-rpc-password = "password" # RPC password
--storage-dir-path = "/tmp/ldk-server/" # Path to store LDK/BDK data

Feel free to open an independent issue for this so it isn't lost.

[moisesPompilio]

Sorry, I meant to post that comment on issue #42. Please disregard it here.