Skip to content

Commit de8a737

Browse files
committed
Don't listen by default
As we expect LDK Node to be primarily used as a client, we should be conservative about listening/accepting inbound connections. The user should make a dedicated choice to do so.
1 parent f5b7238 commit de8a737

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

src/lib.rs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ uniffi::include_scaffolding!("ldk_node");
163163
// Config defaults
164164
const DEFAULT_STORAGE_DIR_PATH: &str = "/tmp/ldk_node/";
165165
const DEFAULT_NETWORK: Network = Network::Bitcoin;
166-
const DEFAULT_LISTENING_ADDR: &str = "0.0.0.0:9735";
167166
const DEFAULT_CLTV_EXPIRY_DELTA: u32 = 144;
168167
const DEFAULT_BDK_WALLET_SYNC_INTERVAL_SECS: u64 = 80;
169168
const DEFAULT_LDK_WALLET_SYNC_INTERVAL_SECS: u64 = 30;
@@ -206,14 +205,14 @@ const WALLET_KEYS_SEED_LEN: usize = 64;
206205
/// | Parameter | Value |
207206
/// |----------------------------------------|------------------|
208207
/// | `storage_dir_path` | /tmp/ldk_node/ |
209-
/// | `network` | `Bitcoin |
210-
/// | `listening_address` | 0.0.0.0:9735 |
208+
/// | `network` | Bitcoin |
209+
/// | `listening_address` | None |
211210
/// | `default_cltv_expiry_delta` | 144 |
212-
/// | `onchain_wallet_sync_interval_secs` | 60 |
213-
/// | `wallet_sync_interval_secs` | 20 |
211+
/// | `onchain_wallet_sync_interval_secs` | 80 |
212+
/// | `wallet_sync_interval_secs` | 30 |
214213
/// | `fee_rate_cache_update_interval_secs` | 600 |
215214
/// | `trusted_peers_0conf` | [] |
216-
/// | `log_level` | `Debug` |
215+
/// | `log_level` | Debug |
217216
///
218217
pub struct Config {
219218
/// The path where the underlying LDK and BDK persist their data.
@@ -253,7 +252,7 @@ impl Default for Config {
253252
Self {
254253
storage_dir_path: DEFAULT_STORAGE_DIR_PATH.to_string(),
255254
network: DEFAULT_NETWORK,
256-
listening_address: Some(DEFAULT_LISTENING_ADDR.parse().unwrap()),
255+
listening_address: None,
257256
default_cltv_expiry_delta: DEFAULT_CLTV_EXPIRY_DELTA,
258257
onchain_wallet_sync_interval_secs: DEFAULT_BDK_WALLET_SYNC_INTERVAL_SECS,
259258
wallet_sync_interval_secs: DEFAULT_LDK_WALLET_SYNC_INTERVAL_SECS,

0 commit comments

Comments
 (0)