f Don't take by reference if we'd need to clone

Author: tnull

README.md

@@ -29,7 +29,7 @@ fn main() {
 
 	let node_id = PublicKey::from_str("NODE_ID").unwrap();
 	let node_addr = "IP_ADDR:PORT".parse().unwrap();
-	node.connect_open_channel(&node_id, &node_addr, 10000, None, false).unwrap();
+	node.connect_open_channel(node_id, node_addr, 10000, None, false).unwrap();
 
 	let invoice = Invoice::from_str("INVOICE_STR").unwrap();
 	node.send_payment(&invoice).unwrap();

src/lib.rs

@@ -47,7 +47,7 @@
 //!
 //! 	let node_id = PublicKey::from_str("NODE_ID").unwrap();
 //! 	let node_addr = "IP_ADDR:PORT".parse().unwrap();
-//! 	node.connect_open_channel(&node_id, &node_addr, 10000, None, false).unwrap();
+//! 	node.connect_open_channel(node_id, node_addr, 10000, None, false).unwrap();
 //!
 //! 	let invoice = Invoice::from_str("INVOICE_STR").unwrap();
 //! 	node.send_payment(&invoice).unwrap();
@@ -853,7 +853,7 @@ impl Node {
 	///
 	/// Returns a temporary channel id.
 	pub fn connect_open_channel(
-		&self, node_id: &PublicKey, address: &SocketAddr, channel_amount_sats: u64,
+		&self, node_id: PublicKey, address: SocketAddr, channel_amount_sats: u64,
 		push_to_counterparty_msat: Option<u64>, announce_channel: bool,
 	) -> Result<(), Error> {
 		let runtime_lock = self.running.read().unwrap();
@@ -869,7 +869,7 @@ impl Node {
 			return Err(Error::InsufficientFunds);
 		}
 
-		let peer_info = PeerInfo { pubkey: node_id.clone(), address: address.clone() };
+		let peer_info = PeerInfo { pubkey: node_id, address };
 
 		let con_peer_pubkey = peer_info.pubkey.clone();
 		let con_peer_addr = peer_info.address.clone();

src/test/functional_tests.rs

@@ -38,8 +38,8 @@ fn channel_full_cycle() {
 	let push_msat = (funding_amount_sat / 2) * 1000; // balance the channel
 	node_a
 		.connect_open_channel(
-			&node_b.node_id(),
-			&node_b.listening_address().unwrap(),
+			node_b.node_id(),
+			*node_b.listening_address().unwrap(),
 			funding_amount_sat,
 			Some(push_msat),
 			true,
@@ -242,8 +242,8 @@ fn channel_open_fails_when_funds_insufficient() {
 	assert_eq!(
 		Err(Error::InsufficientFunds),
 		node_a.connect_open_channel(
-			&node_b.node_id(),
-			&node_b.listening_address().unwrap(),
+			node_b.node_id(),
+			*node_b.listening_address().unwrap(),
 			120000,
 			None,
 			true