Phantom "Upload image" button in forums

[Siderite]

1. Go to a forum
2. Go to the edit form
3. Click the Preview tab
4. Click the Write tab

An "Upload image" button appears, but it has no click handler and does nothing.

[Siderite]

Talking to @SergioGlorias and things work for him. It doesn't work for me in Brave, Firefox and Firefox mobile. I am starting to believe it's some Cloudflare cache thing.

[Siderite]

So I debugged the code and it goes into bits.markdownTextarea, but exits early because it cannot find markdown.dataset.imageUploadUrl.

https://github.com/lichess-org/lila/blob/651e9763a67124b816c771b80a4f02d2aab0d9fc/ui/bits/src/bits.markdownTextarea.ts#L53C8-L53C40

Meaning there are two bugs:

1. imageUploadUrl is not set for me for some reason
2. if the URL is not set, changing tabs between Write and Preview makes the image upload button visible

[Siderite]

This is how my forum textarea looks like:
<div class="markdown-textarea" data-image-download-origin="https://image.lichess1.org" data-image-count-max="5" data-image-design-width="864">

I've traced the code to

lila/modules/ui/src/main/ui/bits.scala

Line 131 in d85c54a

lila.core.security.canUploadImages

That's as far as I can go without compiling Scala in my head.

[schlawg]

an editor with metals would have carried you that last inch.

def canUploadImages(using me: Me) = me.isVerified || (
  lila.core.perm.Granter.ofUser(_.Beta)(me) &&
    (me.createdSinceDays(7) && !me.marks.alt)

if you can't use the button, it means your account is an alt or you're not in the beta group (which apparently is a thing that exists).

[Siderite]

Of course I am not a beta, like all of you guys 🤣

[schlawg]

my account on lichess can't even post. i haven't gotten around to the games yet.