RFE: Add ability to control LEDs of drives behind RAID adapters

[tasleson]

Some raid adapters, like those that use the storcli (megaraid) management utility have the ability to control identification LEDs.

eg.

storcli /cx/ex/sx start locate
storcli /cx/ex/sx stop locate

The library API could be extended to add support for this by adding something like:

def disk_ident_led_on(self, disk, flags=FLAG_RSVD)
def disk_ident_led_off(self, disk, flags=FLAG_RSVD)

int LSM_DLL_EXPORT lsm_disk_ident_led_on(lsm_connect *conn,
                                           lsm_disk *disk, lsm_flag flags);
int LSM_DLL_EXPORT lsm_disk_ident_led_off(lsm_connect *conn,
                                           lsm_disk *disk, lsm_flag flags);

Adding this would resolve:
#479

[napaster]

Faced similar.
We have in stock
5e:00.0 Serial Attached SCSI controller: Broadcom / LSI SAS3216 PCI-Express Fusion-MPT SAS-3 (rev 01)
We are trying to make the baskets blink on it with the following command:
lsmcli local-disk-ident-led-on --path /dev/sda
in response we get this
NO_SUPPORT(153): Failed to find any SCSI enclosure with given SAS address 30016360026ef024

at the same time command:
storcli /c0/s14 start locate

works great:

CLI Version=007.2405.0000.0000 Sep 28, 2022
Operating system = Linux 4.18.0-448.el8.x86_64
Controller = 0
status=success
Description = Start Drive Locate Succeeded

storcli version:
StorCli SAS Customization Utility Ver 007.2405.0000.0000 Sep 28, 2022
    (c)Copyright 2022, Broadcom Inc. All Rights Reserved.

lsmcli --version
/bin/lsmcli 1.9.6

[BenoitKnecht]

@napaster Have you tried exposing the enclosure to the OS? In my case I was using perccli, but the same commands should work with storcli:

# perccli /c0 set backplane expose=on

You can check if it's already exposed with

# perccli /c0 show backplane | grep ^Expose
Expose Backplane ON

Now you should see the enclosure in the output of lsscsi:

# lsscsi | grep enclosu
[0:0:64:0]   enclosu DP       BP_EXP           1.61  -

And lsmcli shouldn't return that error anymore.

[k0ste]

And lsmcli shouldn't return that error anymore.

@BenoitKnecht thanks, yes it should, but

[root@host]# lspci -v | grep SAS -A 2
19:00.0 RAID bus controller: Broadcom / LSI MegaRAID SAS-3 3008 [Fury] (rev 02)
        DeviceName: Integrated RAID
        Subsystem: Dell PERC H330 Adapter
[root@host]# storcli /c0 show backplane J nolog | jq

{
  "Controllers": [
    {
      "Command Status": {
        "CLI Version": "007.3103.0000.0000 Aug 22, 2024",
        "Operating system": "Linux 4.18.0-448.el8.x86_64",
        "Controller": 0,
        "Status": "Success",
        "Description": "None"
      },
      "Response Data": {
        "Controller Properties": [
          {
            "Ctrl_Prop": "BackPlaneState",
            "Value": "auto detect logic of backplanes like SGPIO & i2c SEP"
          },
          {
            "Ctrl_Prop": "Expose Backplane",
            "Value": "ON"
          }
        ]
      }
    }
  ]
}

Backplane exposed

[root@host]# lsscsi | grep enclosu
[0:0:32:0]   enclosu DP       BP14G+EXP        2.52  -

Still get 153

[root@host]# lsmcli local-disk-ident-led-on --path=/dev/sde
NO_SUPPORT(153): controller type unknown and unsupported
[root@host]# lsmcli --version
/bin/lsmcli 1.10.1

[patrakov]

If I paste here the full strace of storcli enabling and disabling the LED, so that we could spy the custom IOCTL or SCSI command out of that, would this break any policies?

[tasleson]

If I paste here the full strace of storcli enabling and disabling the LED, so that we could spy the custom IOCTL or SCSI command out of that, would this break any policies?

LibStorageMgmt as of version 1.10.0 is using functionality from a library interface to https://github.com/intel/ledmon (libled). Any improvements/bug fixes to hardware support will need to be added/corrected there. Additionally, you can try using the ledctl command line to see if you can get additional debug or isolate bug details.

I don't think posting the strace should be an issue, but you may want to pose that question to ledmon before posting it with an issue there.